persistence@glassfish.java.net

Re: JPQL: update fields of embedded instances (issue 1124)

From: Wonseok Kim <guruwons_at_gmail.com>
Date: Mon, 25 Sep 2006 16:26:48 +0900

Hi Michael,

This is not important thing, but I found that your test code missed adding a
newly-added test to the test suite.

The "simpleUnqualifiedUpdate" test method is added in addition to
"updateEmbedded", but it is not added to the suite.
Also, there are typos in line 239 and 250 - "perioid" should be "period".
http://fisheye5.cenqua.com/browse/glassfish/entity-persistence-tests/src/java/oracle/toplink/essentials/testing/tests/ejb/ejbqltesting/JUnitEJBQLModifyTestSuite.java?r1=1.2&r2=1.3

Regards
-Wonseok

On 9/18/06, Michael Bouschen <Michael.Bouschen_at_sun.com> wrote:
>
> Hi Tom, hi Jielin,
>
> I fixed issue 1124 "EJB3.0: Embedded object and path in UPDATE
> statement": https://glassfish.dev.java.net/issues/show_bug.cgi?id=1124
>
> The attached jar JPQL-updateEmbeddeds-060918.jar includes the code
> changes and new tests in entity-persistence-tests. I extended the parse
> to accept a path expression including more than one dot. I also added
> some validation code to the parser node class EqualsAssignmentNode. It
> disallows updating a collection valued relationship field and navigating
> through a relationship field in the target expression of the SET clause.
>
> Thanks!
>
> Regards Michael
>
>
>