Hello Sahoo,
I have reviewed your code and have a suggestion. The Access Type of the Embeddable should still be determined based on annotations or XML (XML can define access type directly). This allows users to specify the access type of the Embeddable. If the access type is not available from the Embeddable then use the access type of the parent. The specification states that the access type can be 'determined' from that of the parent but is not mandated to be that of the parent( Mike, is that not the intention of the specification?) This would give users much more flexibility for sharing Embeddables.
Also based on how TopLink treats Embeddable mappings we could, in the future, support a different access type for each target of an Embeddable mapping if the AccesType of the Embeddable was not supplied by the user.
--Gordon
-----Original Message-----
From: Sanjeeb.Sahoo_at_Sun.COM [mailto:Sanjeeb.Sahoo_at_Sun.COM]On Behalf Of
Sanjeeb Kumar Sahoo
Sent: Monday, August 07, 2006 9:00 AM
To: Tom Ware
Cc: persistence_at_glassfish.dev.java.net
Subject: code review for issue #831
Hi Tom,
Attached here with the suggested fix for
https://glassfish.dev.java.net/issues/show_bug.cgi?id=831 .
The jar file contains modified sources in new folder, original sources
in orig folder and differences in diffs folder.
Please review them. I have update issue tracker with the details.
Tests run:
entity-persistence-tests(all of them passed)
JPA TCK v1.0: 3 tests failed but they fail on a clean workspace as well
(Yes, I have run those 3 tests in a clean workspace and they failed).
So, my changes are not causing those failures.
Appreciate a quick reply.
Thanks,
Sahoo