Changes look good to me as well.
-Tom
Michael Bouschen wrote:
>Hi Jielin,
>
>the change looks good!
>
>Regards Michael
>
>
>
>>Hi, Michael/Tom,
>>
>>I fix the issue 937
>>(https://glassfish.dev.java.net/issues/show_bug.cgi?id=937). The issue
>>is that Chinese characters are not supported in JP query language input
>>parameters. The fix is in EJBQLParser.g. With Georges Murr's help, I
>>tested it with entity that has Chinese identifer, Chinese input
>>parameter and Chinese NamedQuery.
>>
>>Please review the change.
>>
>>Thanks.
>>
>>Jielin
>>
>>
>>