persistence@glassfish.java.net

code reivew for issue 743

From: jielin <Jie.Leng_at_Sun.COM>
Date: Mon, 21 Aug 2006 15:25:42 -0700

Hi, Michael/Tom,

Issue 743 Join of embedded entities should be disallowed is fix in this
jar. Also the unit test for this issue is included. Would you please
review the code?

The changes are:

Added isEmbeddedEntity() API.
entity-persistence/src/java/oracle/toplink/essentials/internal/parsing/TypeHelperImpl.java
entity-persistence/src/java/oracle/toplink/essentials/internal/parsing/TypeHelper.java

Added code for check if the entity is embedded or not
entity-persistence/src/java/oracle/toplink/essentials/internal/parsing/JoinDecNode.java
entity-persistence/src/java/oracle/toplink/essentials/internal/parsing/FetchJoinNode.java

Added EJBQL error message:
entity-persistence/src/java/oracle/toplink/essentials/exceptions/EJBQLException.java
entity-persistence/src/java/oracle/toplink/essentials/exceptions/i18n/EJBQLExceptionResource.java

Added unit test
entity-persistence-tests/src/java/oracle/toplink/essentials/testing/tests/ejb/ejbqltesting/JUnitEJBQLValidationTestSuite.java

Thanks.

Jielin