Hi,
today I checked in a EJB QL compiler change fixing a NPE thrown in
ReportQuery for a query having a constructor expression in the SELECT
clause that takes an aggregate function as an argument:
SELECT NEW custom.CityCount(c.city, COUNT(c)) FROM Customer c
GROUP BY c.city
The ConstructorNode parse tree now uses the ReportQuery API taking Class
instances for the constructor arguments instead of mappings.
The corresponding glassfish issue is:
https://glassfish.dev.java.net/issues/show_bug.cgi?id=310
Reviewed by: Tom Ware
Tests : entity-persistence-tests, local tests
The following files in the entity-persistence module are involved:
M src/java/oracle/toplink/essentials/internal/parsing/AvgNode.java
M
src/java/oracle/toplink/essentials/internal/parsing/BasicTypeHelperImpl.java
M src/java/oracle/toplink/essentials/internal/parsing/ConstructorNode.java
M src/java/oracle/toplink/essentials/internal/parsing/CountNode.java
M src/java/oracle/toplink/essentials/internal/parsing/SelectNode.java
M src/java/oracle/toplink/essentials/internal/parsing/SumNode.java
M src/java/oracle/toplink/essentials/internal/parsing/TypeHelper.java
The following file in the entity-persistence module is involved:
M
src/java/oracle/toplink/essentials/testing/tests/ejb/ejbqltesting/JUnitEJBQLComplexTestSuite.java
cvs commit output:
Checking in
src/java/oracle/toplink/essentials/internal/parsing/AvgNode.java;
new revision: 1.6; previous revision: 1.5
Checking in
src/java/oracle/toplink/essentials/internal/parsing/BasicTypeHelperImpl.java;
asicTypeHelperImpl.java
new revision: 1.2; previous revision: 1.1
Checking in
src/java/oracle/toplink/essentials/internal/parsing/ConstructorNode.java;
new revision: 1.10; previous revision: 1.9
Checking in
src/java/oracle/toplink/essentials/internal/parsing/CountNode.java;
new revision: 1.8; previous revision: 1.7
Checking in
src/java/oracle/toplink/essentials/internal/parsing/SelectNode.java;
new revision: 1.14; previous revision: 1.13
Checking in
src/java/oracle/toplink/essentials/internal/parsing/SumNode.java;
new revision: 1.7; previous revision: 1.6
Checking in
src/java/oracle/toplink/essentials/internal/parsing/TypeHelper.java;
new revision: 1.3; previous revision: 1.2
Checking in
src/java/oracle/toplink/essentials/testing/tests/ejb/ejbqltesting/JUnitEJBQLComplexTestSuite.java;
new revision: 1.7; previous revision: 1.6
Again, I will file an INF notice later.
Regards Michael
--
Michael Bouschen Tech_at_Spree Engineering GmbH
mailto:mbo.tech@spree.de http://www.tech.spree.de/
Tel.:++49/30/235 520-33 Buelowstr. 66
Fax.:++49/30/2175 2012 D-10783 Berlin