Hi Marina,
These changes look good.
-Tom
Marina Vatkina wrote:
>Please review the fix:
>
>Index:
>src/java/oracle/toplink/essentials/internal/ejb/cmp3/xml/PersistenceContentHandler.java
>===================================================================
>RCS file:
>/cvs/glassfish/entity-persistence/src/java/oracle/toplink/essentials/internal/ejb/cmp3/xml/PersistenceContentHandler.java,v
>retrieving revision 1.6
>diff -r1.6 PersistenceContentHandler.java
>123c123
>< String string = stringBuffer.toString();
>---
> > String string = stringBuffer.toString().trim();
>
>
>I also changed persistence.xml in the unit tests for 2 entries (all but one
>type in .xsd is defined as string):
>
>Index: config/META-INF/persistence.xml
>===================================================================
>RCS file: /cvs/glassfish/entity-persistence-tests/config/META-INF/persistence.xml,v
>retrieving revision 1.14
>diff -r1.14 persistence.xml
>3,4c3,8
><
><provider>oracle.toplink.essentials.ejb.cmp3.EntityManagerFactoryProvider</provider>
>< <mapping-file>META-INF/advanced-entity-mappings.xml</mapping-file>
>---
> > <provider>
> >
>oracle.toplink.essentials.ejb.cmp3.EntityManagerFactoryProvider
> > </provider>
> > <mapping-file>
> > META-INF/advanced-entity-mappings.xml
> > </mapping-file>
>
>
>The changed files are attached. If you feel strong about changing all entries in
>the test's persistence.xml, let me know.
>
>thanks,
>-marina
>
>
--
Tom Ware
Principal Software Engineer
Oracle Canada Inc.
Direct: (613) 783-4598
Email: tom.ware_at_oracle.com