persistence@glassfish.java.net

code review for issue 146

From: jie leng <jie.leng_at_Sun.COM>
Date: Wed, 22 Mar 2006 17:10:35 -0800

Hi, Tom, Michael,

Here is the code change for issue 146 - JPQL validation: Parser not
catching invalid argument type used with MOD.

With more validation in ModNode, for the query

select o from Order o WHERE MOD(o.totalPrice, 10) = 5.

The EJBQLException will be throwed:

     [java] Caused by: Exception [TOPLINK-8020] (Oracle TopLink
Essentials - 2006.3 (Build 060319)):
oracle.toplink.essentials.exceptions.EJBQLException
     [java] Exception Description: Invalid MOD argument [o.totalPrice],
expected an integral data type.

Please review the code.

Thanks.

Jielin