Hi Pramod,
Sorry, I thought I had written you back.
This change looks fine,
Tom
Pramod Gopinath wrote:
> Hi Tom
> Any updates for my proposed change related to issue 433.
>
> Pramod
>
> Pramod Gopinath wrote:
>
>> Hi Tom
>>
>> Based on Marina's input to this issue
>> https://glassfish.dev.java.net/issues/show_bug.cgi?id=433
>>
>> have made the following change to the PostgresSQLPlatform :
>>
>> override the method shouldUseJDBCOuterJoinSyntax() to return "false".
>>
>> Can U review this change ?
>>
>> Thanks
>>
>> Pramod
>>
>>------------------------------------------------------------------------
>>
>>Index: src/java/oracle/toplink/essentials/platform/database/PostgreSQLPlatform.java
>>===================================================================
>>RCS file: /cvs/glassfish/entity-persistence/src/java/oracle/toplink/essentials/platform/database/PostgreSQLPlatform.java,v
>>retrieving revision 1.5
>>diff -r1.5 PostgreSQLPlatform.java
>>326a327,333
>>
>>
>>> /**
>>> * JDBC defines and outer join syntax, many drivers do not support this. So we normally avoid it.
>>> */
>>> public boolean shouldUseJDBCOuterJoinSyntax() {
>>> return false;
>>> }
>>>
>>>
>
--
Tom Ware
Principal Software Engineer
Oracle Canada Inc.
Direct: (613) 783-4598
Email: tom.ware_at_oracle.com