The entity-persistence change looks good.
-Tom
Marina Vatkina wrote:
>Tom,
>
>Please review changes to entity-persistence - rename the value and make
>the string public:
>
>Index: src/java/oracle/toplink/essentials/ejb/cmp3/EntityManagerFactoryProvider.java
>===================================================================
>RCS file:
>/cvs/glassfish/entity-persistence/src/java/oracle/toplink/essentials/ejb/cmp3/EntityManagerFactoryProvider.java,v
>retrieving revision 1.24
>diff -r1.24 EntityManagerFactoryProvider.java
>66c66
>< private static final String TOPLINK_VALIDATION_ONLY_PROPERTY =
>"oracle.toplink.essentials.ValidationOnly";
>---
> > public static final String TOPLINK_VALIDATION_ONLY_PROPERTY =
>"toplink.validation-only";
>
>Sahoo,
>
>Change verifier code to use public strings instead of the hardcoded
>values:
>
>Index:
>src/tools/com/sun/enterprise/tools/verifier/tests/persistence/DefaultProviderVerification.java
>===================================================================
>RCS file:
>/cvs/glassfish/avk/src/tools/com/sun/enterprise/tools/verifier/tests/persistence/DefaultProviderVerification.java,v
>retrieving revision 1.7
>diff -r1.7 DefaultProviderVerification.java
>70c70,71
>< props.put("oracle.toplink.essentials.ValidationOnly", "TRUE"); // NOI18N
>---
> > props.put(EntityManagerFactoryProvider.TOPLINK_VALIDATION_ONLY_PROPERTY,
> > "TRUE"); // NOI18N
>74c75,76
>< props.put("toplink.orm.throw.exceptions", "TRUE"); // NOI18N
>---
> > props.put(EntityManagerFactoryProvider.TOPLINK_ORM_THROW_EXCEPTIONS,
> > "TRUE"); // NOI18N
>
>the changed files are attached.
>QLook and unit tests passed.
>
>Sahoo,
>
>I ran verifier against ex1-ee.ear (Java EE persistence example):
>bin/verifier ex1-ee.ear
> INFO: Verifying: [ ex1-ee.ear ]
> INFO: Verifying: [ ejb_jar ]
>Visiting non-standard Signature object
>Visiting non-standard Signature object
>Visiting non-standard Signature object
> INFO: Verifying: [ client_jar ]
>Visiting non-standard Signature object
>Visiting non-standard Signature object
>Visiting non-standard Signature object
> INFO:
># of Failures : 0
># of Warnings : 0
># of Errors : 0
>
>
>Are these messages expected?
>
>thanks,
>-marina
>
>
--
Tom Ware
Principal Software Engineer
Oracle Canada Inc.
Direct: (613) 783-4598
Email: tom.ware_at_oracle.com