dev@glassfish.java.net

Re: POM review for the new admin console test suite

From: Romain Grecourt <romain.grecourt_at_oracle.com>
Date: Wed, 16 Oct 2013 16:27:07 +0200

Hi Jeremy,

Do you plan to add more modules to appserver/tests/admingui ?
If not, please merge the 2 poms into one.

If you keep those two poms, can you define an inheritance and add all
dependencies and plugins version into the dependencyManagement and
pluginManagement section of the parent ?
Also, I'd like to understand this trick:

             <plugin>
                 <artifactId>maven-surefire-plugin</artifactId>
                 <version>2.7.1</version>
                 <dependencies>
/ <dependency>
                         <groupId>org.apache.maven.surefire</groupId>
                         <artifactId>surefire-junit47</artifactId>
                         <version>2.7.1</version>
                     </dependency>/
                 </dependencies>
                 <configuration>
                     <forkMode>never</forkMode>
                 </configuration>
             </plugin>

Thanks,
Romain

On 10/16/13 2:08 PM, lvsongping wrote:
>
> Hi, Romain:
>
> Cc: dev list:
>
> As we have discussed yesterday, the new test suite should be check
> into the directory under appserv/tests/admingui module and the POM
> should be reviewed first before checked all of the test suites. So
> please review my POM I have attached.
>
> regards
>
> Jeremy Lv
>
> --------------------------------------------------
>
> Lv Songping
>
> Software Division II
>
> Development Department I
>
> Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST)
>
> ADDR.: No.6 Wenzhu Road, Software Avenue,
>
> Nanjing, 210012, China
>
> TEL : +86+25-86630566-9327
>
> COINS: 7998-9327
>
> FAX : +86+25-83317685
>
> MAIL : lvsongping_at_cn.fujitsu.com <mailto:lvsongping_at_cn.fujitsu.com>
>
> BLOG : https://www.java.net//author/jeremy-lv
> <https://www.java.net/author/jeremy-lv>
>