dev@glassfish.java.net

Re: copyright checker maven plugin

From: Bill Shannon <bill.shannon_at_oracle.com>
Date: Wed, 10 Aug 2011 16:22:20 -0700

I can wait. :-)

I'm still testing and enhancing. And still looking for a code reviewer...

Snjezana Sevo-Zenzerovic wrote on 08/10/11 04:08 PM:
> I believe that Jane already moved glassfish maven plugin into separate workspace under GlassFish project so we should probably use the same location for this one. She is back from vacation tomorrow so if you can wait for another day she should be able to fill in the details.
>
> Thanks,
>
> Snjezana
>
> ----- Original Message -----
> From: bill.shannon_at_oracle.com
> To: dev_at_glassfish.java.net
> Sent: Wednesday, August 10, 2011 3:42:53 PM GMT -08:00 US/Canada Pacific
> Subject: Re: copyright checker maven plugin
>
> The copyright plugin doesn't depend on any GlassFish artifacts.
> I just need to put the source somewhere. Starting another java.net
> project just for it seems excessive.
>
> Justin Lee wrote on 08/10/11 03:31 PM:
>> Well, we do because we can't depend on any artifacts from glassfish.
>> That circularity will almost certainly come back to bite us.
>>
>> On 8/10/11 6:03 PM, Jason Lee wrote:
>>> Once the plugin is in a Maven repo, who cares where the source is, right?
>>>
>>> On 8/10/11 4:46 PM, Justin Lee wrote:
>>>> I would ask that it not be in the glassfish repo as projects outside
>>>> glassfish depend on it. We can't use it in grizzly if we have to
>>>> build glassfish first. I suppose we could end run the circular dep
>>>> with profiles but that doesn't really those grizzly contributors who
>>>> don't have glassfish to build.
>>>>
>>>> On 8/10/11 4:52 PM, Bill Shannon wrote:
>>>>> I've turned my copyright checker into a maven plugin.
>>>>>
>>>>> Who can review the code for me?
>>>>>
>>>>> What groupID/artifactID should I use for it?
>>>>> Currently I'm using org.glassfish:glassfish-copyright-maven-plugin.
>>>>>
>>>>> Should I create a new module under trunk to contain it? (Where are
>>>>> all the
>>>>> other plugins these days? Should I put it there?)
>>>>>
>>>>>
>>>>> Jane Young wrote on 07/27/11 12:30 PM:
>>>>>> We can probably add a mojo to our existing maven-glassfishbuild-plugin
>>>>>> to check for copyright header.
>>>>>> We probably want to display a warning, not failing the build.
>>>>>> However, it will be hard for the user to notice this warning in the
>>>>>> build output.
>>>>>> Another option is to add profile in the build that checks for
>>>>>> copyright
>>>>>> header.
>>>>>> What do you prefer?
>>>>>>
>>>>>>
>>>>>>
>>>>>> On 7/27/11 12:19 PM, Bill Shannon wrote:
>>>>>>> Tim Quinn wrote on 07/27/11 11:41 AM:
>>>>>>>>
>>>>>>>> On Jul 27, 2011, at 1:12 PM, Byron Nevins wrote:
>>>>>>>>
>>>>>>>>> KUDOS to whomever invented and implemented this idea. I almost
>>>>>>>>> always forget
>>>>>>>>> to update the copyright year. ..
>>>>>>>>
>>>>>>>> Indeed.
>>>>>>>>
>>>>>>>> Now, if this technology can be built into a maven plug-in that's run
>>>>>>>> automatically as part of our builds in our own workspaces, so we can
>>>>>>>> find out
>>>>>>>> BEFORE we check in the offending files...
>>>>>>>
>>>>>>> Where's that "Beginner's Guide to Writing Maven Plugins"? :-)
>>>>>>>
>>>>>>> What's an existing (simple) maven plugin that does something similar,
>>>>>>> i.e., analyzes all the source code in a project?
>>>>>>
>>>>>
>>>
>>>
>