dev@glassfish.java.net

Re: pom.xml review

From: Tom Mueller <tom.mueller_at_oracle.com>
Date: Mon, 08 Aug 2011 08:56:34 -0500

LGTM.

On 8/8/2011 8:44 AM, Jennifer Chou wrote:
> This change is for removing the dependency on stats77 from
> monitoring-core, so monitoring-core can be moved to nucleus.
> These classes which depend on stats77
>
> com.sun.enterprise.admin.monitor.registry.*
> com.sun.enterprise.admin.monitor.stats.*
> com.sun.enterprise.admin.monitor.stats.lb.*
>
> will be moved from monitoring-core to stats77.
>
> Index: common/stats77/osgi.bundle
> ===================================================================
> --- common/stats77/osgi.bundle (revision 48629)
> +++ common/stats77/osgi.bundle (working copy)
> @@ -38,4 +38,8 @@
> # holder.
> #
>
> --exportcontents: org.glassfish.j2ee.statistics;
> version=${project.osgi.version}
> +-exportcontents: \
> + com.sun.enterprise.admin.monitor.registry; \
> + com.sun.enterprise.admin.monitor.stats; \
> + com.sun.enterprise.admin.monitor.stats.lb; \
> + org.glassfish.j2ee.statistics;
> version=${project.osgi.version}
> Index: admin/monitor/osgi.bundle
> ===================================================================
> --- admin/monitor/osgi.bundle (revision 48629)
> +++ admin/monitor/osgi.bundle (working copy)
> @@ -40,9 +40,6 @@
>
> -exportcontents: \
> com.sun.enterprise.admin.monitor.jndi; \
> - com.sun.enterprise.admin.monitor.registry; \
> - com.sun.enterprise.admin.monitor.stats; \
> - com.sun.enterprise.admin.monitor.stats.lb; \
> com.sun.enterprise.admin.monitor.util; \
> com.sun.enterprise.management.support; \
> org.glassfish.flashlight; \
> Index: admin/monitor/pom.xml
> ===================================================================
> --- admin/monitor/pom.xml (revision 48629)
> +++ admin/monitor/pom.xml (working copy)
> @@ -115,11 +115,6 @@
> </plugins>
> </build>
> <dependencies>
> - <dependency>
> - <groupId>org.glassfish.common</groupId>
> - <artifactId>stats77</artifactId>
> - <version>${project.version}</version>
> - </dependency>
> <dependency>
> <groupId>org.glassfish.common</groupId>
> <artifactId>common-util</artifactId>