dev@glassfish.java.net

Re: [3.1.1] Review request for Glassfish-17039, Addition of new module jsr109-glue

From: Marina Vatkina <marina.vatkina_at_oracle.com>
Date: Fri, 15 Jul 2011 17:54:44 -0700

Did those checkins add modules or just moved code around?

Hong Zhang wrote:
> While avoid loading a single module gives us a small improvement, they
> do add up. There were a few similar check ins happened yesterday and
> we saw performance gain with today's nightly.
>
> On 7/15/2011 7:53 PM, Shing Wai Chan wrote:
>> In this case, do we measure the performance improvement?
>> Thanks.
>> Shing Wai Chan
>>
>> On 7/15/11 4:38 PM, Marina Vatkina wrote:
>>> What is the benefit of loading a new module instead of the old one
>>> and in addition having extra modules loaded eventually and always in
>>> the classpath?
>>>
>>> thanks,
>>> -marina
>>>
>>> Hong Zhang wrote:
>>>> Snjezana: this change is for 3.1.1 (for performance improvement).
>>>> Rama: thanks for taking care of this. Please verify the jsr109-impl
>>>> module is no longer loaded after the deployment with this change.
>>>>
>>>> - Hong
>>>>
>>>> On 7/15/2011 6:46 PM, Snjezana Sevo-Zenzerovic wrote:
>>>>> Pom changes look fine. One nit: please correct copyright year in
>>>>> new osgi-bundle file to 2011.
>>>>>
>>>>> Also, please remember that you will need to wait with trunk merge
>>>>> until trunk workspace reopens.
>>>>>
>>>>> Thanks,
>>>>>
>>>>> Snjezana
>>>>>
>>>>> ----- Original Message -----
>>>>> From: Rama.Pulavarthi_at_oracle.com
>>>>> To: dev_at_glassfish.java.net, hong.hz.zhang_at_oracle.com,
>>>>> snjezana.sevozenzerovic_at_oracle.com
>>>>> Sent: Friday, July 15, 2011 3:42:33 PM GMT -08:00 US/Canada Pacific
>>>>> Subject: [3.1.1] Review request for Glassfish-17039, Addition of
>>>>> new module jsr109-glue
>>>>>
>>>>> Please review the patch for Glassfish-17039:
>>>>> http://java.net/jira/browse/GLASSFISH-17039 that has changes to
>>>>> packager/metro/pom.xml and webservices modules.
>>>>> Web Services AnnotationHandlers are moved into a new module
>>>>> jsr109-glue under webservices.
>>>>>
>>>>> thanks,
>>>>> Rama Pulavarthi
>>