dev@glassfish.java.net

Re: SSH2 dependency added to logging

From: Jerome Dochez <jerome.dochez_at_oracle.com>
Date: Wed, 1 Sep 2010 09:03:24 -0700

that will not completely work as cluster related commands like CollectLogFiles will still appear in the nucleus distribution, right ?

jerome

On Aug 31, 2010, at 11:20 PM, Sanjeeb Sahoo wrote:

> I don't think we need to move classes around. I had told Naman to have optional dependency on SSH. Atleast that's how the OSGi metadata is setup:
>
> org.glassfish.cluster.ssh.launcher;resolution:=optional;version="3.1",org.glassfish.cluster.ssh.sftp;resolution:=optional;version="3.1"
>
> The logging code is also written such that it works in the absence of SSH packages. So, I think if logging adds a provided scope dependency on SSH artifacts, things will be sorted out.
>
> Sahoo
>
> On Wednesday 01 September 2010 11:33 AM, Jerome Dochez wrote:
>> Naman
>>
>> I believe you are the one who added the LogFilterForInstance and other cluster related classes like CollectLogFiles in the logging module. We cannot have such dependencies added to a module that ships with nucleus and not clustered distributions (like the RI).
>>
>> Can you move those classes to a cluster specific module like admin-cluster or define a new module logging-cluster to add those capabilities there.
>>
>> thanks, jerome
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>
>>
>