dev@glassfish.java.net

review request (jersey jars in v2 clobbering v3)

From: Bobby Bissett <bobby.bissett_at_oracle.com>
Date: Thu, 23 Sep 2010 15:20:08 -0400

Hi all,

The upgrade tool, before telling asadmin to perform an upgrade, attempts to copy 3rd party jars from <gfv2>/lib to <gfv3>/lib. If both lib dirs are found, it does a deep copy and excludes certain files that are part of v2 that we don't want in v3. I don't know where the original exclude lists actually came from(*), but I want to add these jar files to the lists. Without this change, the admin console can't come up if the upgrade was performed with the upgrade tool (just copying over the domain and doing the upgrade from the command line is fine).

Issue filed:
https://glassfish.dev.java.net/issues/show_bug.cgi?id=13591

Anyone have a problem with this change? I'll take 1 day of silence as a "no":

hostname% pwd
/Users/bobby/work/ws/v3/extras/upgrade/upgrade-jar
hostname% svn diff
Index: src/main/resources/com/sun/enterprise/tools/upgrade/common/macV2LibExcludeList.properties
===================================================================
--- src/main/resources/com/sun/enterprise/tools/upgrade/common/macV2LibExcludeList.properties (revision 41070)
+++ src/main/resources/com/sun/enterprise/tools/upgrade/common/macV2LibExcludeList.properties (working copy)
@@ -102,3 +102,10 @@
 verifier
 webservices-rt.jar
 webservices-tools.jar
+
+# These are present in v2.1.1
+asm-3.1.jar
+jackson-asl-0.9.4.jar
+jersey-bundle-1.0.3.1.jar
+jettison-1.0.1.jar
+jsr311-api-1.0.jar
Index: src/main/resources/com/sun/enterprise/tools/upgrade/common/unixV2LibExcludeList.properties
===================================================================
--- src/main/resources/com/sun/enterprise/tools/upgrade/common/unixV2LibExcludeList.properties (revision 41070)
+++ src/main/resources/com/sun/enterprise/tools/upgrade/common/unixV2LibExcludeList.properties (working copy)
@@ -113,3 +113,10 @@
 toplink-essentials.jar
 webservices-rt.jar
 webservices-tools.jar
+
+# These are present in v2.1.1
+asm-3.1.jar
+jackson-asl-0.9.4.jar
+jersey-bundle-1.0.3.1.jar
+jettison-1.0.1.jar
+jsr311-api-1.0.jar
Index: src/main/resources/com/sun/enterprise/tools/upgrade/common/winV2LibExcludeList.properties
===================================================================
--- src/main/resources/com/sun/enterprise/tools/upgrade/common/winV2LibExcludeList.properties (revision 41070)
+++ src/main/resources/com/sun/enterprise/tools/upgrade/common/winV2LibExcludeList.properties (working copy)
@@ -110,3 +110,10 @@
 toplink-essentials.jar
 webservices-rt.jar
 webservices-tools.jar
+
+# These are present in v2.1.1
+asm-3.1.jar
+jackson-asl-0.9.4.jar
+jersey-bundle-1.0.3.1.jar
+jettison-1.0.1.jar
+jsr311-api-1.0.jar

Thanks,
Bobby


(*) The exclude lists are here: http://tinyurl.com/2cb6ac9