Thanks, Sahoo.
This is the new diff for review. I still have 2 questions I'd like to
double check with you and osgi experts here:
We now use comma (not semi-comma) at the end of line 1, but still use
semi-comma at the end of line 2 and 3. Is that OK?
We use include:= (not include=) in line 1, is it OK? I suppose there
are subtle difference between the 2, or may be interchangeable. In
verifier-impl/osgi.bundle, include= is used.
/Users/cf126330/glassfish-svn/trunk/v3/common/glassfish-naming > svn diff
Index: osgi.bundle
===================================================================
--- osgi.bundle (revision 38358)
+++ osgi.bundle (working copy)
@@ -1,5 +1,6 @@
Bundle-Activator: com.sun.enterprise.naming.util.NamingActivator
-exportcontents: \
+ com.sun.enterprise.naming;
include:="SerialInitContextFactory"; version=${project.osgi.version}, \
com.sun.enterprise.naming.impl; \
com.sun.enterprise.naming.spi; \
com.sun.enterprise.naming.util;
version=${project.osgi.version}
-cheng
On 7/5/10 11:09 AM, Sanjeeb Sahoo wrote:
> Sorry, you need to do something like the following for the entire
> header to be parsed correctly:
> -exportcontents: \
> com.sun.enterprise.naming;
> include:="SerialInitContextFactory"; version=${project.osgi.version}, \
> ...
>
> The "," and ";" make a lot of difference.
>
> On Monday 05 July 2010 08:35 PM, Sanjeeb Sahoo wrote:
>> You can do something like this:
>>
>> -exportcontents: \
>> com.sun.enterprise.naming;
>> include:="SerialInitContextFactory"\
>> to export only that class.
>>
>> Sahoo
>>
>> On Monday 05 July 2010 07:46 PM, Cheng Fang wrote:
>>> Hi,
>>>
>>> Please review the change to common/glassfish-naming/osgi.bundle:
>>>
>>> /Users/cf126330/glassfish-svn/trunk/v3/common/glassfish-naming > svn
>>> diff
>>> Index: osgi.bundle
>>> ===================================================================
>>> --- osgi.bundle (revision 38358)
>>> +++ osgi.bundle (working copy)
>>> @@ -1,5 +1,6 @@
>>> Bundle-Activator: com.sun.enterprise.naming.util.NamingActivator
>>> -exportcontents: \
>>> + com.sun.enterprise.naming; \
>>> com.sun.enterprise.naming.impl; \
>>> com.sun.enterprise.naming.spi; \
>>> com.sun.enterprise.naming.util;
>>> version=${project.osgi.version}
>>>
>>>
>>> This is to fix issue
>>> https://glassfish.dev.java.net/issues/show_bug.cgi?id=12084 (Unable
>>> to lookup using SerialInitContextFactory and ClassNotFound thrown).
>>>
>>> I'm adding com.sun.enterprise.naming; to the list of exports.
>>> There are 2 classes in this package:
>>>
>>> ll src/main/java/com/sun/enterprise/naming/
>>> total 24
>>> -rw-r--r-- 1 staff 7884 May 13 10:55 GlassFishNamingBuilder.java
>>> -rw-r--r-- 1 staff 3057 May 13 10:55 SerialInitContextFactory.java
>>> drwxr-xr-x 20 staff 680 May 13 10:55 util/
>>> drwxr-xr-x 18 staff 612 May 13 10:55 impl/
>>> drwxr-xr-x 5 staff 170 May 13 10:55 spi/
>>>
>>> To fix the issue I only need to export
>>> com.sun.enterprise.naming.SerialInitContextFactory. Is there a way
>>> to export a single class in osgi.bundle? If no, then we will have
>>> to export this package.
>>>
>>> Thanks,
>>> -cheng
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>