On Tuesday 06 July 2010 12:19 AM, Cheng Fang wrote:
> Thanks, Sahoo.
>
> This is the new diff for review. I still have 2 questions I'd like to
> double check with you and osgi experts here:
>
> We now use comma (not semi-comma) at the end of line 1, but still use
> semi-comma at the end of line 2 and 3. Is that OK?
Yes. "," is used as a package-group separator, where as ";" is used as a
package separator.
>
> We use include:= (not include=) in line 1, is it OK? I suppose there
> are subtle difference between the 2, or may be interchangeable. In
> verifier-impl/osgi.bundle, include= is used.
verifier is wrong. I will fix it.
>
> /Users/cf126330/glassfish-svn/trunk/v3/common/glassfish-naming > svn diff
> Index: osgi.bundle
> ===================================================================
> --- osgi.bundle (revision 38358)
> +++ osgi.bundle (working copy)
> @@ -1,5 +1,6 @@
> Bundle-Activator: com.sun.enterprise.naming.util.NamingActivator
> -exportcontents: \
> + com.sun.enterprise.naming;
> include:="SerialInitContextFactory"; version=${project.osgi.version}, \
> com.sun.enterprise.naming.impl; \
> com.sun.enterprise.naming.spi; \
> com.sun.enterprise.naming.util;
> version=${project.osgi.version}
>
>
Looks fine. Test it before checking in.
Sahoo