If we look at the Hudson log,
http://gf-hudson.sfbay.sun.com/hudson/view/GFv3%20Trunk/job/gf-trunk-build-continuous/4666/consoleText
we have
pass:
fail:
[echo] ======================================================================
[echo] FAILED: check-logged-messages
[echo] Issues found in one or more messages (see results above).
[echo] Please address them, or if the message should be left as-is,
[echo] add it to the exclusion list with details why it should be excluded:
[echo] /export/home1/java_re/BUILD_AREA/workspace/gf-trunk-build-continuous/v3/tests/quicklook/gfproject/log_msg_excl.txt
[echo] ======================================================================
[INFO] Executed tasks
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESSFUL
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 2 minutes 59 seconds
[INFO] Finished at: Thu Jun 24 12:59:24 PDT 2010
[INFO] Final Memory: 22M/255M
[INFO] ------------------------------------------------------------------------
Buildfile: build.xml
initprops:
report:
[echo] Generating report at /export/home1/java_re/BUILD_AREA/workspace/gf-trunk-build-continuous/v3/tests/quicklook/test-output
[junitreport] the file /export/home1/java_re/BUILD_AREA/workspace/gf-trunk-build-continuous/v3/tests/quicklook/test-output/testng-results.xml is not a valid testsuite XML document
[junitreport] Processing /export/home1/java_re/BUILD_AREA/workspace/gf-trunk-build-continuous/v3/tests/quicklook/test-output/TESTS-TestSuites.xml to /export/home1/java_re/BUILD_AREA/workspace/gf-trunk-build-continuous/v3/tests/quicklook/test-output/junit-noframes.html
[junitreport] Loading stylesheet jar:file:/net/repine.sfbay/export2/hudson/tools/ant-1.7.0/lib/ant-junit.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-noframes.xsl
[junitreport] Transform time: 224ms
[echo] Test Report available at /export/home1/java_re/BUILD_AREA/workspace/gf-trunk-build-continuous/v3/tests/quicklook/test-output/index.html
BUILD SUCCESSFUL
It seems that the "fail:" does not trigger a Hudson failure.
What do we try to test here?
Shing Wai Chan
On 6/24/10 3:44 PM, Marina Vatkina wrote:
> Removing lines with the message Ids from the output (why are they
> reported as not having them?) this is what's left (and none is from my
> changes):
>
> [echo] * Messages with no proper message Id:
> [echo]
> /System/Library/Frameworks/JavaVM.framework/Versions/1.6/Home/bin/java
> [echo] Jun 24, 2010 2:59:33 PM null
> [echo] class
> com.sun.jersey.multipart.impl.FormDataMultiPartDispatchProvider
> [echo] class com.sun.jersey.multipart.impl.MultiPartConfigProvider
> [echo] class com.sun.jersey.multipart.impl.MultiPartReader
> [echo] class com.sun.jersey.multipart.impl.MultiPartWriter|#]
> [echo] class
> com.sun.jersey.multipart.impl.FormDataMultiPartDispatchProvider
> [echo] class com.sun.jersey.multipart.impl.MultiPartConfigProvider
> [echo] class com.sun.jersey.multipart.impl.MultiPartReader
> [echo] class com.sun.jersey.multipart.impl.MultiPartWriter|#]
> [echo]
> /System/Library/Frameworks/JavaVM.framework/Versions/1.6/Home/bin/java
> [echo] Jun 24, 2010 3:07:09 PM null
>
>
> Best,
> -marina
>
>
> Jane Young wrote:
>> Okay, I see the check-logged-message target:
>>
>> check-logged-messages:
>> [echo] Checking messages in:
>> [echo]
>> /BUILD_AREA/workspace/gf-trunk-build-continuous/gfv3-gp/glassfishv3/glassfish/domains/domain1/logs/server.log
>>
>> [echo] [copy] Copying 1 file to
>> /export/home1/java_re/BUILD_AREA/workspace/gf-trunk-build-continuous/v3/tests/test-output
>>
>> [echo]
>> [echo] * Message keys logged instead of message:
>> [echo] (none)
>> [echo]
>>
>> Ming, can you answer Marina's question.
>>
>> Thanks,
>> Jane
>>
>>
>> Marina Vatkina wrote:
>>> I'm asking what the check-logged-messages test does and how to
>>> decipher its output?
>>>
>>> thanks,
>>> -marina
>>>
>>> Jane Young wrote:
>>>> I'm not sure what you're asking. But you can check if QL tests are
>>>> passing on Hudson:
>>>> http://hudson.glassfish.org/job/gf-trunk-build-continuous/
>>>> If Hudson tests are passing and your local QL tests are failing
>>>> then it may be related to your changes.
>>>>
>>>> Marina Vatkina wrote:
>>>>> What does its long output mean and how can I check if I broke
>>>>> anything?
>>>>>
>>>>> thanks,
>>>>> -marina
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>