Looks fine. Thanks for fixing this.
Jane
Trilok wrote:
> Hi Jane
> you were right the modified_mvn was indeed masking genuine errors
> apart from maven re-threading bug
>
> here is the current modified_mvn
> modified_mvn() {
> set +e
> *mvn $**
> set +x
> nawk '/java.lang.NullPointerException/ {getline; print}'
> /net/repine.sfbay.sun.com/export2/hudson/jobs/${JOB_NAME}/builds/${BUILD_NUMBER}/log
> | grep
> 'org.codehaus.plexus.component.configurator.converters.lookup.DefaultConverterLookup.findConverterForType(DefaultConverterLookup.java:115)'
> > /dev/null
> if [ $? -eq 0 ]
> then
> echo "found a mvn rethreading bug instance, and re-spining the build"
> mvn $*
> fi
> set -x
> set -e
> }
>
> and here is the modified_mvn
> modified_mvn() {
> set +e
> *mvn $*
> export EXIT_CODE=$?
> if [ **EXIT_CODE** -ne 0 ]
> then
> *set +x
> nawk '/java.lang.NullPointerException/ {getline; print}'
> /net/repine.sfbay.sun.com/export2/hudson/jobs/${JOB_NAME}/builds/${BUILD_NUMBER}/log
> | grep
> 'org.codehaus.plexus.component.configurator.converters.lookup.DefaultConverterLookup.findConverterForType(DefaultConverterLookup.java:115)'
> > /dev/null
> if [ $? -eq 0 ]
> then
> echo "found a mvn rethreading bug instance, and re-spining the build"
> *set -e*
> mvn $*
> *else
> exit $EXIT_CODE
> *fi
> set -x
> *fi*
> set -e
> }
>
> In the modified version, the rethreading error is only checked if the
> mvn $* invocation fails.
>
> Please let me know if you think of any other use case that is not
> caught with this new implementation
>
> Thx
> TRILOK
> Jane Young wrote:
>> Hi Trilok,
>>
>> hudson.glassfish.org is the external Hudson. You'll need to login to
>> gf-hudson.sfbay.sun.com.
>>
>> Thanks for looking into this.
>> Jane
>>
>>
>> Trilok wrote:
>>> Hi Jane
>>> I will also look into this,
>>> But I am unable to log in to hudson.glassfish.org
>>> Did something change over the weekend
>>>
>>> Please let me know
>>> Thx
>>> TRILOK
>>> Jane Young wrote:
>>>> Hong,
>>>>
>>>> Thanks for fixing the build.
>>>> The dev hudson job reported the build failure but not the
>>>> continuous job.
>>>>
>>>> http://hudson.glassfish.org/job/gf-trunk-build-dev/
>>>> http://hudson.glassfish.org/job/gf-trunk-build-continuous/
>>>>
>>>> The recent change in the hudson continuous job for the maven
>>>> threading workaround is masking build failures. I will fix that.
>>>>
>>>> Thanks again.
>>>> Jane
>>>>
>>>>
>>>>
>>>> Hong Zhang wrote:
>>>>> I have written to Romain asking him to investigate. Not sure if he
>>>>> is still on line (he is in France). I am trying to fix the build
>>>>> myself too in the meantime.
>>>>>
>>>>> Yamini K B wrote:
>>>>>> I'm hitting the same problem!
>>>>>>
>>>>>> -Yamini
>>>>>>
>>>>>> Byron Nevins wrote:
>>>>>>> [INFO] [resources:resources]
>>>>>>> [INFO] Using default encoding to copy filtered resources.
>>>>>>> [INFO] [hk2:hk2-compile]
>>>>>>> [INFO] Compiling 4 source files to
>>>>>>> /home1/java_re/BUILD_AREA/workspace/gf-trunk-build-dev/v3/deployment/javaee-core/target/classes
>>>>>>>
>>>>>>> /home1/java_re/BUILD_AREA/workspace/gf-trunk-build-dev/v3/deployment/javaee-core/src/main/java/org/glassfish/javaee/core/deployment/ListSubComponentsCommand.java:114:
>>>>>>> cannot find symbol
>>>>>>> symbol : method getIdentifier(java.lang.String)
>>>>>>> location: class
>>>>>>> org.glassfish.deployment.versioning.VersioningService
>>>>>>> versioningService.getIdentifier(applicationName);
>>>>>>> ^
>>>>>>> Note:
>>>>>>> /home1/java_re/BUILD_AREA/workspace/gf-trunk-build-dev/v3/deployment/javaee-core/src/main/java/org/glassfish/javaee/core/deployment/ListSubComponentsCommand.java
>>>>>>> uses unchecked or unsafe operations.
>>>>>>> Note: Recompile with -Xlint:unchecked for details.
>>>>>>> 1 error
>>>>>>> [INFO]
>>>>>>> ------------------------------------------------------------------------
>>>>>>>
>>>>>>> [ERROR] BUILD ERROR
>>>>>>> [INFO]
>>>>>>> ------------------------------------------------------------------------
>>>>>>>
>>>>>>> [INFO] Fatal error compiling
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --------------
>>>>>>> Is anyone looking at this?
>>>>>>>
>>>>>>>
>>>>>>> Embedded error: APT failed: 1
>>>>>>>
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>>>
>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>
>