dev@glassfish.java.net

Re: [REVIEW] for 3.0.1

From: Bill Shannon <bill.shannon_at_oracle.com>
Date: Tue, 27 Apr 2010 12:23:51 -0700

I've thought for some time that we ought to expand the
osgiversion-maven-plugin to support more general version
manipulation, so we can take some base version string and
convert it to whatever other formats are needed.

Do we need much more than a general regular expression replacement?

Snjezana Sevo-Zenzerovic wrote on 04/27/10 12:12 PM:
> Certainly...
>
> The version string in that file is eventually used as the version string
> for IPS packages which contain grizzly content and this is what you see
> if you query the content of the official GlassFish distribution in
> updatetool or Update section of Admin GUI. Same goes for update packages
> available in update center.
>
> Reason we cannot simply reuse Grizzly version from the top level pom is
> that IPS is stricter than maven when it comes to version string format,
> so for the time being you need to translate grizzly version to the one
> IPS can handle. Note that even if you don't rev up the version, actual
> package produced by promoted build will still contain your updated
> content and be handled as and update due to newer timestamp, but it is
> generally good idea to rev up the version number for each new drop -
> that way you know for certain which grizzly build provided content for
> the particular version of grizzly related packages.
>
> HTH...
>
> Justin Lee wrote:
>> I always forget about that file. Partly because I have no idea what
>> it's for? Can you enlighten me on that one? I'll update that file
>> either way.
>>
>> On 4/27/10 2:28 PM, Snjezana Sevo-Zenzerovic wrote:
>>> I am not sure how religious you were lately with Grizzly build number
>>> update in packager grizzly package version, but you may want to also
>>> rev up the last number in grizzly_version value in
>>> packager/pkg_conf.py.template...
>>>
>>> Thanks,
>>>
>>> Snjezana
>>>
>>> Justin Lee wrote:
>>>> Anyone still around to approve this patch to the branch? This fixes
>>>> a timeout issue which broke for CTS.
>>>> ------------------------------------------------------------------------
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>
>>>
>
>