dev@glassfish.java.net

Re: Resend: [REVIEW REQUEST] (was: Re: Seeking review for top level pom changes

From: Jerome Dochez <Jerome.Dochez_at_Sun.COM>
Date: Wed, 21 Oct 2009 14:21:05 -0700

On Oct 21, 2009, at 2:01 PM, Ed Burns wrote:

>>>>>> On Wed, 21 Oct 2009 13:34:50 -0700, Jerome Dochez <Jerome.Dochez_at_Sun.COM
>>>>>> > said:
>
> JD> you fail the same BV quicklook test than last friday. I just
> reverted
> JD> this integration.
>
> I ran the quicklook tests on MacOS X and Solaris, with in glassfish
> and
> web profile, with security manager enabled and disabled, and it worked
> for me. I don't know what else I have to do to not have my changes
> kicked back out.
>
> JD> this is what you need to do to test before you commit your
> changes :
>
> JD> - take a fresh hk2 workspace.
> JD> - change the BV version to whatever you like
> JD> - build hk2 -> you will get snapshots version of the hk2 modules
> JD> like : 0.4.4-SNAPSHOT
> JD> - take a fresh v3 workspace
> JD> - edit top level pom.xml and change hk2.version and
> hk2.plugin.version
> JD> from 0.4.3 to 0.4.4-SNAPSHOT (these are examples)
> JD> - build the entire workspace
> JD> - run tests as described in the tests/quicklook directory.
>
> Yes, I did exactly these steps.
>
you must do something wrong b/c when I was building v3 against hk2
snapshots after your checkin yesterday, I could see that the BV test
was failing.

I just turned blue after reverting
http://gf-hudson.sfbay.sun.com/hudson/job/gf-trunk-build-continuous/2920/

> Ed
>
> --
> | ed.burns_at_sun.com | office: 408 884 9519 OR x31640
> | homepage: | http://ridingthecrest.com/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>