dev@glassfish.java.net

Re: Resend: [REVIEW REQUEST]

From: Sahoo <Sahoo_at_Sun.COM>
Date: Thu, 22 Oct 2009 11:29:17 +0530

Ed Burns wrote:
>>>>>> On Wed, 21 Oct 2009 13:34:50 -0700, Jerome Dochez <Jerome.Dochez_at_Sun.COM> said:
>>>>>>
>
> JD> you fail the same BV quicklook test than last friday. I just reverted
> JD> this integration.
>
> I ran the quicklook tests on MacOS X and Solaris, with in glassfish and
> web profile, with security manager enabled and disabled, and it worked
> for me. I don't know what else I have to do to not have my changes
> kicked back out.
>
> JD> this is what you need to do to test before you commit your changes :
>
> JD> - take a fresh hk2 workspace.
> JD> - change the BV version to whatever you like
> JD> - build hk2 -> you will get snapshots version of the hk2 modules
> JD> like : 0.4.4-SNAPSHOT
> JD> - take a fresh v3 workspace
> JD> - edit top level pom.xml and change hk2.version and hk2.plugin.version
> JD> from 0.4.3 to 0.4.4-SNAPSHOT (these are examples)
> JD> - build the entire workspace
> JD> - run tests as described in the tests/quicklook directory.
>
> Yes, I did exactly these steps.
>
I am not sure what is the case with your setup, but when I tried to use
HK2 version 0.4.4-SNAPSHOT as mentioned above, I observed one QL
failure. Since I need a newer version of HK2 later today, I have
reverted your BV integration in HK2 as shown below:
ss141213_at_Sahoo:/space/ss141213/WS/hk2/trunk$ svn commit -m "Revert back
to bean-validator version 3.0-JBoss-4.0.0.Beta3A"
Sending config/pom.xml
Transmitting file data .
Committed revision 1295.

Thanks,
Sahoo
> Ed
>
>