Bill Shannon wrote:
> The tool seems to be checking both the src and target directories.
You are correct. I can remove the target directories from the output.
>
> How do you know if a message is *supposed* to have a message id?
The assumption I am making is that all messages in the file being analyzed
(e.g. LogStrings.properties) must have a message id .
>
>
> Red and green text is not the best choice of colors. Better to add
> text or separate the output into two lists.
What is the problem with red and green ? After I sent the message, I did
notice that the colors (green in particular) was hard to read on another
display ( not my PC). I still like the color encoding scheme. Perhaps I
can
look at web safe colors.
>
>
> Assuming the tool can produce accurate output, it should use svn to find
> out who last changed the line with the missing message id and send that
> person email telling them to fix it. For extra credit, automatically
> create a bug report to track the issue. :-)
I will defer this for now until I get through other issues.
Sekhar
>
>
> Chandrasekhar Vajjhala wrote:
>> Hi,
>>
>> To assist in locating and fixing messages with missing message ID, I
>> wrote
>> a tool. I ran the tool against the LogStrings.properties files in the
>> GlassFish V3 workspace,
>> and uploaded the output to GlassFish wiki page at [1] . I also linked
>> [1] off the
>> GlassFish Serviceability page [2] .
>>
>> Take a look at the the summary at the top of [1] for information on
>> locating messages that need
>> to be fixed, statistics on files, messages etc.
>>
>> Note:
>> a. My workspace is about a couple of weeks old.
>> b. I will rerun the tool periodically for now.
>> c. I am looking into integrating the tool into GlassFish v3 build
>> using maven.
>>
>> Sekhar
>>
>> [1]
>> http://wiki.glassfish.java.net/attach/GlassFishV3LoggingServiceability/LogStrings-msgidlist.html?version=3
>>
>> [2]
>> http://wiki.glassfish.java.net/Wiki.jsp?page=GlassFishV3LoggingServiceability
>>
>>
>> On 10/02/09 16:55, Jerome Dochez wrote:
>>> Hi all
>>>
>>> Please review your modules for presence of logging activities at
>>> SEVERE, WARNING, INFO levels with messages that are not
>>> internationalized.
>>> As you know all messages above INFO level must be internationalized.
>>>
>>> While you are at it, please review that such messages have a message
>>> ID, see [1].
>>>
>>> If you find messages above INFO level which are not
>>> internationalized, you must do either :
>>>
>>> 1. add the proper string lookup from the local strings.
>>> 2. lower the level if the message is a necessity to the user's
>>> understanding of the situation.
>>>
>>> I would rather see (1) of course.
>>>
>>>
>>> Jerome
>>>
>>> [1]
>>> http://wiki.glassfish.java.net/Wiki.jsp?page=GlassFishV3LoggingMessageFormat
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>