dev@glassfish.java.net

JANE: Seeking POM review (was: Re: If you get a StackOverflowError in the build)

From: Ed Burns <Ed.Burns_at_Sun.COM>
Date: Fri, 16 Oct 2009 13:08:55 -0700

>>>>> On Fri, 16 Oct 2009 11:06:23 -0700, Jane Young <Jane.Young_at_Sun.COM> said:

JY> Ed,
JY> You're already deployed it with the same version. I reset the cache on
JY> Nexus so we should be fine now.
JY> But next time please do not deploy to maven repo with the same
JY> version.

Ok. Here are a set of changes to hk2 pom.xml files that declare a new
dependency on a new version of bean-validator. I'm waiting for that new
version to appear in the repo. In the meantime, I'd like you, Jane, to
review these changes. I have one question: These changes make it so
only the hk2 config module has a dependency on bean-validator. For all
the other hk2 modules that depend on config, the bean-validator
transitive dependency has been excluded. Will this be enough to make
sure v3 gets bean-validator?

SECTION: Changes

M hk2/pom.xml
M auto-depends-tests/test2/pom.xml
M core/pom.xml
M config-generator/pom.xml
M config-types/pom.xml

- exclude bean-validator from being picked up as a transitive dependency

M config/pom.xml

- This is the one hk2 artifact that *does* have an honest bean-validator
  dependency. Upgrade it to 4.0.1_01, which fixes the pom problems.

SECTION: Diffs

Index: hk2/pom.xml
===================================================================
--- hk2/pom.xml (revision 1233)
+++ hk2/pom.xml (working copy)
@@ -55,6 +55,12 @@
             <groupId>com.sun.enterprise</groupId>
             <artifactId>config</artifactId>
             <version>${project.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.glassfish</groupId>
+ <artifactId>bean-validator</artifactId>
+ </exclusion>
+ </exclusions>
         </dependency>
         <dependency>
             <groupId>com.sun.enterprise</groupId>
Index: auto-depends-tests/test2/pom.xml
===================================================================
--- auto-depends-tests/test2/pom.xml (revision 1233)
+++ auto-depends-tests/test2/pom.xml (working copy)
@@ -35,6 +35,12 @@
       <groupId>com.sun.enterprise</groupId>
       <artifactId>config</artifactId>
       <version>${version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.glassfish</groupId>
+ <artifactId>bean-validator</artifactId>
+ </exclusion>
+ </exclusions>
     </dependency>
   </dependencies>
 </project>
Index: core/pom.xml
===================================================================
--- core/pom.xml (revision 1233)
+++ core/pom.xml (working copy)
@@ -50,6 +50,12 @@
             <groupId>com.sun.enterprise</groupId>
             <artifactId>config</artifactId>
             <version>${project.parent.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.glassfish</groupId>
+ <artifactId>bean-validator</artifactId>
+ </exclusion>
+ </exclusions>
         </dependency>
     </dependencies>
     <profiles>
Index: config-generator/pom.xml
===================================================================
--- config-generator/pom.xml (revision 1233)
+++ config-generator/pom.xml (working copy)
@@ -16,6 +16,12 @@
             <groupId>com.sun.enterprise</groupId>
             <artifactId>config</artifactId>
             <version>${project.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.glassfish</groupId>
+ <artifactId>bean-validator</artifactId>
+ </exclusion>
+ </exclusions>
         </dependency>
         <dependency>
             <groupId>com.sun.enterprise</groupId>
Index: config/pom.xml
===================================================================
--- config/pom.xml (revision 1233)
+++ config/pom.xml (working copy)
@@ -93,7 +93,7 @@
         <dependency>
             <groupId>org.glassfish</groupId>
             <artifactId>bean-validator</artifactId>
- <version>3.0-JBoss-4.0.1</version>
+ <version>3.0-JBoss-4.0.1_01</version>
         </dependency>
     </dependencies>
     <profiles>
Index: config-types/pom.xml
===================================================================
--- config-types/pom.xml (revision 1233)
+++ config-types/pom.xml (working copy)
@@ -69,6 +69,12 @@
             <groupId>com.sun.enterprise</groupId>
             <artifactId>config</artifactId>
             <version>${project.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.glassfish</groupId>
+ <artifactId>bean-validator</artifactId>
+ </exclusion>
+ </exclusions>
         </dependency>
     </dependencies>
-</project>
\ No newline at end of file
+</project>

-- 
| ed.burns_at_sun.com  | office: 408 884 9519 OR x31640
| homepage:         | http://ridingthecrest.com/