dev@glassfish.java.net

Re: changes to the upgrade code?

From: Kedar Mhaswade <Kedar.Mhaswade_at_Sun.COM>
Date: Wed, 14 Oct 2009 15:52:35 -0700

Byron Nevins wrote:
> This is in the default V3 domain.xml template in nucleus
>
> <log-service file="${com.sun.aas.instanceRoot}/logs/server.log"
> log-rotation-limit-in-bytes="2000000">
> <module-log-levels />
> </log-service>
>
> It is still in there after running V3 over and over again
>
> For laughs I ran 'asadmin start-domain --upgrade' on this same **V3**
> installation.
>
> And sure enough it removed the log-service element.
>
> Is this just me or is this really weird?
>
> 1) Why does upgrade run at all on a V3 installation? Shouldn't it know
> it is not really an upgrade?
Well, that's not entirely true. Some component can change from release
to release and maybe build to build. "--upgrade" is a switch that
enables all those SchemaUpdaters to run. In v3, there is nothing like
a top-level version that dictates if all components are up-to-date.

> 2) Why is log-service in the nucleus default domain.xml. Isn't it just
> a source of confusion?
You are right. It's wrong.

Carla, can you remove this element from v3's vanilla domain.xml (
in packager/nucleus-base/lib/templates/domain.xml)?


>
>
>
> Bill Shannon wrote:
>
>> Carla Mott wrote on 10/14/09 12:11:
>>
>>>
>>> Recall that the logging info is in domain.xml and that it needs to be
>>> moved to logging.properties. That was done in UpgradeLogging the
>>> first time that the server came up until recently. Now I see that
>>> the info is in 2 places, domain.xml and logging.properties in the
>>> latest v3 releases.
>>
>>
>> I don't understand.
>>
>> Is the logging information *always* in domain.xml? Is that supposed to
>> be the master source of the logging information, that is always copied
>> to logging.properties on startup?
>>
>> If so, then UpgradeLogging should have nothing to do with the -upgrade
>> option.
>>
>> I thought the logging information was in domain.xml in previous releases,
>> and was only in logging.properties in v3. In that case, I don't know why
>> it would be in domain.xml in v3.
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>
>