dev@glassfish.java.net

CommandRunner

From: Bill Shannon <bill.shannon_at_sun.com>
Date: Thu, 01 Oct 2009 00:43:12 -0700

If you have code that uses the CommandRunner API, please read this
message carefully...

In order to allow admin commands to accept multiple operands (for
compatibility with v2), I replaced uses of Properties to pass
command arguments with a new class ParameterMap. ParameterMap
is a MultiMap<String,String>, which means that each key (parameter
name) can have multiple values.

Typical use of the CommandRunner/CommandInvocation API is:

        commandRunner.getCommandInvocation(...).parameters(props).execute();

The use of a Properties object for props has been changed to a
ParameterMap object.

I've fixed all of the callers in the GlassFish workspace to use
ParameterMap. Some of them were fixed to simply copy data from
a Properties object to a ParameterMap object because changing
everything to use a ParameterMap object was too extensive. The
REST code was a particular problem.

Within Sun you can review the (pending) changes at:
http://javaweb.sfbay/~shannon/glassfish/webrev-multiple/

The list of files I touched is below.

===> If you own any of these files, please review the changes. <===

I'll check in these changes as soon as svn is working and I'm able
to merge the changes with the current versions.

Thanks.


deployment/autodeploy/src/main/java/org/glassfish/deployment/autodeploy/AutoOperation.java
orb/orb-connector/src/test/java/org/glassfish/orb/admin/cli/ListIiopListenersTest.java
orb/orb-connector/src/test/java/org/glassfish/orb/admin/cli/DeleteIiopListenerTest.java
orb/orb-connector/src/test/java/org/glassfish/orb/admin/cli/CreateIiopListenerTest.java
core/kernel/src/test/java/com/sun/enterprise/v3/admin/ConfigAttributeSetTest.java
core/kernel/src/test/java/com/sun/enterprise/v3/admin/CreateProfilerTest.java
core/kernel/src/test/java/com/sun/enterprise/v3/admin/CommandRunnerTest.java
core/kernel/src/test/java/com/sun/enterprise/v3/admin/AdminAdapterTest.java
core/kernel/src/main/java/org/glassfish/kernel/embedded/EmbeddedAdminCtrImpl.java
core/kernel/src/main/java/com/sun/enterprise/v3/server/DynamicReloader.java
core/kernel/src/main/java/com/sun/enterprise/v3/server/AppServerStartup.java
core/kernel/src/main/java/com/sun/enterprise/v3/admin/AdminAdapter.java
core/kernel/src/main/java/com/sun/enterprise/v3/admin/LocalStrings.properties
core/kernel/src/main/java/com/sun/enterprise/v3/admin/CommandRunnerImpl.java
core/kernel/src/main/java/com/sun/enterprise/v3/admin/SetCommand.java
jdbc/admin/src/test/java/org/glassfish/jdbc/admin/cli/ListJdbcResourcesTest.java
jdbc/admin/src/test/java/org/glassfish/jdbc/admin/cli/DeleteJdbcResourceTest.java
jdbc/admin/src/test/java/org/glassfish/jdbc/admin/cli/CreateJdbcResourceTest.java
common/glassfish-api/src/main/java/org/glassfish/api/Param.java
common/glassfish-api/src/main/java/org/glassfish/api/admin/CommandRunner.java
common/glassfish-api/src/main/java/org/glassfish/api/admin/ParameterMap.java
common/glassfish-api/src/main/java/org/glassfish/api/embedded/admin/CommandParameters.java
admin/config-api/src/main/java/org/glassfish/config/support/GenericCRUDCommand.java
admin/rest/src/main/java/org/glassfish/admin/rest/ResourceUtil.java
jms/admin/src/main/java/org/glassfish/jms/admin/cli/JMSPing.java
jms/admin/src/main/java/org/glassfish/jms/admin/cli/DeleteJMSResource.java
jms/admin/src/main/java/org/glassfish/jms/admin/cli/CreateJMSResource.java
admingui/common/src/main/java/org/glassfish/admingui/common/util/LocalDeploymentFacility.java
jbi/serviceengine/sun-javaee-engine/src/main/java/com/sun/enterprise/jbi/serviceengine/util/LocalDeploymentFacility.java
ant-tasks/src/main/java/org/glassfish/ant/embedded/tasks/AdminTask.java
connectors/admin/src/test/java/org/glassfish/connectors/admin/cli/DeleteJavaMailResourceTest.java
connectors/admin/src/test/java/org/glassfish/connectors/admin/cli/DeleteJndiResourceTest.java
connectors/admin/src/test/java/org/glassfish/connectors/admin/cli/CreateJavaMailResourceTest.java
connectors/admin/src/test/java/org/glassfish/connectors/admin/cli/CreateJndiResourceTest.java
connectors/admin/src/test/java/org/glassfish/connectors/admin/cli/ListCustomResourcesTest.java
connectors/admin/src/test/java/org/glassfish/connectors/admin/cli/DeleteCustomResourceTest.java
connectors/admin/src/test/java/org/glassfish/connectors/admin/cli/CreateCustomResourceTest.java
connectors/admin/src/test/java/org/glassfish/connectors/admin/cli/ListJndiResourcesTest.java
connectors/admin/src/test/java/org/glassfish/connectors/admin/cli/ListJavaMailResourcesTest.java