So, um, what's next? Do I need to file a bug to get this changed to
FINE level? If so, anyone care if I just change the log level?
Cheers,
Bobby
On Sep 23, 2009, at 5:43 PM, Justin Lee wrote:
> No, the user shouldn't have to do anything about it. I had
> rewritten it to use DOM so that ordering wouldn't really matter as
> much but that was shot down so we're back to STAX. We probably
> don't really need to output that message in any case since it's not
> something the user really needs to worry about...
>
> Bill Shannon wrote:
>> We don't really expect users to do anything about this warning,
>> right?
>> It's not like we're expecting them to open domain.xml in an editor
>> and
>> rearrange the elements, right? I don't see any point in displaying
>> this
>> warning. I would log this at FINE or lower.
>>
>> And can't we make the MiniXmlParser code, or the code using it, more
>> resilient so it doesn't need to parse the file twice?
>>
>>
>> Justin Lee wrote on 09/23/09 06:55:
>>> That message should go away after the upgrade as the upgrade
>>> process would result in a properly ordered document. Though, in
>>> my opinion, relying on order in an XML document is "bad" but
>>> that's the nature of STAX.
>>>
>>> Bobby Bissett wrote:
>>>> Starting with a v2 domain, the following message comes from the
>>>> parser during an upgrade and then from every start-domain and
>>>> stop-domain after that:
>>>>
>>>>> Sep 22, 2009 5:32:05 AM
>>>>> com.sun.enterprise.universal.xml.MiniXmlParser read
>>>>> WARNING: XML file was parsed twice because the configs element
>>>>> appears before the servers element. To prevent this waste of
>>>>> time, move the servers element before the configs element.
>>>>
>>>> Since we've (hopefully) conditioned users not to edit domain.xml
>>>> manually, could we change that warning to Level.INFO or even
>>>> lower? This could also be changed by the upgrade service to move
>>>> the elements around, but I doubt anyone wants to own that right
>>>> now. Besides seeing that warning in the console at every start/
>>>> stop, it also makes the upgrade tool pass along a "warning or
>>>> error detected" message to the user at every upgrade. I can work
>>>> around that, but it would add an odd dependency to the upgrade
>>>> tool to detect that specific message in the asadmin output.
>>>>
>>>> Cheers,
>>>> Bobby
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>