Jan,
Change looks fine in case you are waiting for the review.
Thanks,
Sahoo
Jan Luehe wrote:
> Turns out I'm the culprit.
>
> I had removed the package in question when moving the
> ProxyHandler.java interface from
> com.sun.appserv.security.provider to com.sun.appserv, which is the
> package it used to belong to
> in GlassFish v2.1 and earlier releases. Thanks, Sahoo, for pointing
> this out to me!
>
> I'm about to commit the following diffs for
> common/container-common/osgi.bundle:
>
> Index: osgi.bundle
> ===================================================================
> --- osgi.bundle (revision 31011)
> +++ osgi.bundle (working copy)
> @@ -1,5 +1,4 @@
> -exportcontents: \
> - com.sun.appserv.security.provider; \
> com.sun.enterprise.container.common; \
> com.sun.enterprise.container.common.impl; \
> com.sun.enterprise.container.common.impl.util; \
>
> Thanks,
>
> Jan
>>
>> Kumar, have you had a chance to look at this yet?
>>
>> Sahoo wrote on 8/25/09 9:52 PM:
>>
>>> Jane,
>>>
>>> I don't think there is any single person responsible for
>>> container-common. You are right, that package is not part of the jar
>>> being built. From the package name, it appears that some one from
>>> security team would have done some refactoring which caused this
>>> regression.
>>>
>>> Kumar,
>>> can you please take a look?
>>>
>>> Thanks,
>>> Sahoo
>>>
>>> Jane Young wrote:
>>>
>>>> Is "com.sun.appserv.security.provider" in container-common.jar? If
>>>> not then it should be removed from "-exportcontents" in osgi.bundle.
>>>> Who is the owner of common/container-common?
>>>>
>>>>
>>>>
>>>> Bill Shannon wrote:
>>>>
>>>>> When I build common/container-common it complains:
>>>>>
>>>>> [WARNING] Warning in manifest for
>>>>> org.glassfish.common:container-common:hk2-jar:3.0-SNAPSHOT : Superfluous
>>>>> export-package instructions: [com.sun.appserv.security.provider]
>>>>>
>>>>>
>>>>> Anyone know any reason why that's not just a bug that should be fixed?
>>>>>
>>>>> And if it's not a bug, how do we make it stop complaining?
>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>>
>>>>>
>>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>
>>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>
>>
>