dev@glassfish.java.net

Re: pom change review

From: Ludovic Champenois <Ludovic.Champenois_at_Sun.COM>
Date: Fri, 21 Aug 2009 13:50:44 -0700

On 8/21/09 12:00 PM, Snjezana Sevo-Zenzerovic wrote:
> Wait, there is even more nagging :-)
>
> Since we get both mimepull and jersey-multipart jars into final
> distribution from jersey package image, you should set dependency
> scope for both of these to "provided" - same as for jersey-server
> dependency which is already in the pom...
>
> Thanks,
>
> Snjezana
>
> Jane Young wrote:
>
>> Hi Ludo,
>> ...

Thanks for the review process, this is helpful.

So my new changes are now:

admin/rest pom:
--- pom.xml Base (BASE)
+++ pom.xml Locally Modified (Based On LOCAL)
@@ -101,6 +101,21 @@
<groupId>org.glassfish.external</groupId>
<artifactId>management-api</artifactId>
</dependency>
+
+ <dependency>
+ <groupId>org.jvnet</groupId>
+ <artifactId>mimepull</artifactId>
+ <version>${mimepull.version}</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>com.sun.jersey.contribs</groupId>
+ <artifactId>jersey-multipart</artifactId>
+ <version>${jersey-multipart.version}</version>
+ <scope>provided</scope>
+ </dependency>
+
+
</dependencies>
<build>
<resources>


and v3/pom.xml:
Index: pom.xml
--- pom.xml Base (BASE)
+++ pom.xml Locally Modified (Based On LOCAL)
@@ -162,6 +162,8 @@
<wsdl4j.version>1.6.2</wsdl4j.version>
<gmbal.version>3.0.0-b009</gmbal.version>
<glassfish-management-api.version>3.0.0-b004</glassfish-management-api.version>
+ <mimepull.version>1.4</mimepull.version>
+ <jersey-multipart.version>1.1.1-ea</jersey-multipart.version>
</properties>


@@ -934,6 +936,17 @@
<artifactId>webui-jsf-suntheme</artifactId>
<version>${woodstock.version}</version>
</dependency>
+
+ <dependency>
+ <groupId>org.jvnet</groupId>
+ <artifactId>mimepull</artifactId>
+ <version>${mimepull.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>com.sun.jersey.contribs</groupId>
+ <artifactId>jersey-multipart</artifactId>
+ <version>${jersey-multipart.version}</version>
+ </dependency>
</dependencies>
</dependencyManagement>
<!-- End: Dependency management -->


Clean build +simple test worked.

Let me know,
Thanks,
Ludo