May want to look into adding the dependencies in the top level pom.xml's
dependencyManagement.
Other than that the changes look good.
Anissa Lam wrote:
>
> Please review the following changes for 3.0-Preview branch. We need
> to upgrade to woodstock 4.3.0.8.
> While doing this, I notice there shouldn't be dependency on it in one
> of the plugin, so i removed that .
>
> thanks
> Anissa.
>
>
> Index: admingui/community-theme/pom.xml
> ===================================================================
> --- admingui/community-theme/pom.xml (revision 27239)
> +++ admingui/community-theme/pom.xml (working copy)
> @@ -139,13 +139,5 @@
> <artifactId>console-plugin-service</artifactId>
> <version>${project.version}</version>
> </dependency>
> - <dependency>
> - <groupId>com.sun.woodstock</groupId>
> - <artifactId>webui-jsf-suntheme</artifactId>
> - <version>4.3.0.7</version>
> - <scope>compile</scope>
> - </dependency>
> -
> -
> </dependencies>
> </project>
> Index: admingui/pom.xml
> ===================================================================
> --- admingui/pom.xml (revision 27239)
> +++ admingui/pom.xml (working copy)
> @@ -151,12 +151,12 @@
> <dependency>
> <groupId>com.sun.woodstock</groupId>
> <artifactId>webui-jsf-suntheme</artifactId>
> - <version>4.3.0.7</version>
> + <version>4.3.0.8</version>
> </dependency>
> <dependency>
> <groupId>com.sun.woodstock</groupId>
> <artifactId>webui-jsf</artifactId>
> - <version>4.3.0.7</version>
> + <version>4.3.0.8</version>
> <exclusions>
> <exclusion>
> <groupId>com.sun.faces.extensions</groupId>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>