I haven't heard from others after i sent this out, so i assume others
don't have any objections.
I also talked with Jane about this, and get her ok on this.
I will be checking in the changes soon.
The files changed will be :
admingui/common/pom.xml
admingui/core/pom.xml
admingui/web/pom.xml
All of them will add these dependencies.
<dependency>
<groupId>org.glassfish.common</groupId>
<artifactId>amx-core</artifactId>
<version>${project.version}</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.glassfish.common</groupId>
<artifactId>amx-config</artifactId>
<version>${project.version}</version>
<scope>provided</scope>
</dependency>
thanks
Anissa.
Anissa Lam wrote:
>
> Hi Jane,
>
> Thanks for reviewing this.
>
> Jane Young wrote:
>> Question.
>>
>> I notice that the dependency is with "scope provided" thus disabling
>> the transitivity of the dependency. Is there a reason for this?
> We have "scope provided" in all the dependencies specified in all
> the admingui modules. I believe thats for preventing including all
> the jars in the admingui.war. So, i just follow the same practice.
> I don't feel comfortable removing that now. Can i follow this same
> pattern as all other dependencies for today and then make all the
> modification for other dependencies all at once ?
>
>> Both admingui/core/pom.xml and v3/admingui/web/pom.xml have
>> dependency on admingui/common/pom.xml. Since the scope is provided,
>> you need to add amx-core dependency in both modules.
> Yes, thats why all core/pom.xml, web/pom.xml and common/pom.xml
> specify the dependency of "amx-core".
>
> After I send the diff out, I realize i need to add 1 more
> dependency, "amx-config".
> Here is the latest diff. I still keep the scope as 'provide'.
>
> thanks
> Anissa.
>
> Index: admingui/common/pom.xml
> ===================================================================
> --- admingui/common/pom.xml (revision 26440)
> +++ admingui/common/pom.xml (working copy)
> @@ -117,6 +117,18 @@
> <scope>provided</scope>
> </dependency>
> <dependency>
> + <groupId>org.glassfish.common</groupId>
> + <artifactId>amx-core</artifactId>
> + <version>${project.version}</version>
> + <scope>provided</scope>
> + </dependency>
> + <dependency>
> + <groupId>org.glassfish.common</groupId>
> + <artifactId>amx-config</artifactId>
> + <version>${project.version}</version>
> + <scope>provided</scope>
> + </dependency>
> + <dependency>
> <groupId>com.sun.jsftemplating</groupId>
> <artifactId>jsftemplating</artifactId>
> <version>${jsftemplating.version}</version>
> Index: admingui/core/pom.xml
> ===================================================================
> --- admingui/core/pom.xml (revision 26440)
> +++ admingui/core/pom.xml (working copy)
> @@ -117,6 +117,18 @@
> <scope>provided</scope>
> </dependency>
> <dependency>
> + <groupId>org.glassfish.common</groupId>
> + <artifactId>amx-core</artifactId>
> + <version>${project.version}</version>
> + <scope>provided</scope>
> + </dependency>
> + <dependency>
> + <groupId>org.glassfish.common</groupId>
> + <artifactId>amx-config</artifactId>
> + <version>${project.version}</version>
> + <scope>provided</scope>
> + </dependency>
> + <dependency>
> <groupId>org.glassfish.security</groupId>
> <artifactId>securitycommon</artifactId>
> <version>${project.version}</version>
> Index: admingui/war/pom.xml
> ===================================================================
> --- admingui/war/pom.xml (revision 26440)
> +++ admingui/war/pom.xml (working copy)
> @@ -58,7 +58,7 @@
> <archive>
> <manifestEntries>
>
> <Glassfish-require-services>org.glassfish.api.admingui.ConsoleProvider</Glassfish-require-services>
>
> -
> <HK2-Import-Bundles>org.glassfish.admingui.console-common,com.sun.enterprise.hk2,org.glassfish.admingui.console-plugin-service,
> org.glassfish.common.amx-api,
> org.glassfish.deployment.deployment-client,org.glassfish.registration.registration-api,org.glassfish.registration.registration-impl,
> org.glassfish.javax.servlet, org.glassfish.javax.servlet.jsp,
> com.sun.jsftemplating, org.glassfish.admingui.dataprovider,
> com.sun.pkg.client </HK2-Import-Bundles>
> +
> <HK2-Import-Bundles>org.glassfish.admingui.console-common,com.sun.enterprise.hk2,org.glassfish.admingui.console-plugin-service,
> org.glassfish.common.amx-api, org.glassfish.common.amx-core,
> org.glassfish.common.amx-config,
> org.glassfish.deployment.deployment-client,org.glassfish.registration.registration-api,org.glassfish.registration.registration-impl,
> org.glassfish.javax.servlet, org.glassfish.javax.servlet.jsp,
> com.sun.jsftemplating, org.glassfish.admingui.dataprovider,
> com.sun.pkg.client </HK2-Import-Bundles>
> </manifestEntries>
> </archive>
> </configuration>
> @@ -110,7 +110,7 @@
> <archive>
> <manifestEntries>
>
> <Glassfish-require-services>org.glassfish.api.admingui.ConsoleProvider</Glassfish-require-services>
>
> -
> <HK2-Import-Bundles>org.glassfish.admingui.console-common,com.sun.enterprise.hk2,org.glassfish.admingui.console-plugin-service,
> org.glassfish.common.amx-api,
> org.glassfish.deployment.deployment-client,org.glassfish.registration.registration-api,org.glassfish.registration.registration-impl,
> org.glassfish.javax.servlet, org.glassfish.javax.servlet.jsp,
> com.sun.jsftemplating,
> org.glassfish.admingui.dataprovider,com.sun.pkg.client</HK2-Import-Bundles>
>
> +
> <HK2-Import-Bundles>org.glassfish.admingui.console-common,com.sun.enterprise.hk2,org.glassfish.admingui.console-plugin-service,
> org.glassfish.common.amx-api, org.glassfish.common.amx-core,
> org.glassfish.common.amx-config,
> org.glassfish.deployment.deployment-client,org.glassfish.registration.registration-api,org.glassfish.registration.registration-impl,
> org.glassfish.javax.servlet, org.glassfish.javax.servlet.jsp,
> com.sun.jsftemplating,
> org.glassfish.admingui.dataprovider,com.sun.pkg.client</HK2-Import-Bundles>
>
> </manifestEntries>
> </archive>
> <webResources>
> Index: admingui/web/pom.xml
> ===================================================================
> --- admingui/web/pom.xml (revision 26440)
> +++ admingui/web/pom.xml (working copy)
> @@ -108,6 +108,18 @@
> <scope>provided</scope>
> </dependency>
> <dependency>
> + <groupId>org.glassfish.common</groupId>
> + <artifactId>amx-core</artifactId>
> + <version>${project.version}</version>
> + <scope>provided</scope>
> + </dependency>
> + <dependency>
> + <groupId>org.glassfish.common</groupId>
> + <artifactId>amx-config</artifactId>
> + <version>${project.version}</version>
> + <scope>provided</scope>
> + </dependency>
> + <dependency>
> <groupId>org.glassfish.deployment</groupId>
> <artifactId>deployment-client</artifactId>
> <version>${project.version}</version>
>
>
>>
>