Mitesh,
Can you move all the eclipselink dependencies to v3/pom.xml's
dependencyManagement section? If you want to do it post branch creation,
that's fine too as long as you remember to do it. Since you are changing
the file now, you may just make this change.
BTW, the name is certainly confusing, as the pom says:
<name>Repackaging of EclipseLink as a module</name>
My previous email was triggered by the above line. How else can one
interpret the above line?
Thanks,
Sahoo
Mitesh Meswani wrote:
> We are not wrapping EclipseLink in any form This module exist just to
> declare dependencies on EclipseLink so that we package EclipseLink
> with GlassFish. The proposed changes are to upgrade version of
> EclipseLink we bundle. Are you ok with these changes?
> Do you think there is a more elegant way to pull in EclipseLink
> without using the eclipselink-wrapped module? If yes, we can implement
> it post branch creation for java one.
>
> Thanks,
> Mitesh
>
> Sahoo wrote:
>> Why are we still wrapping eclipselink?
>>
>> Thanks,
>> Sahoo
>>
>> Mitesh Meswani wrote:
>>> Jane, Sahoo, Jerome,
>>>
>>> Can you please review following pom.xml changes to upgrade to
>>> EclipseLink 2.0.0-M2.1
>>>
>>> Please note that I have moved property eclipselink.version to top
>>> level pom to keep it close to corresponding
>>> javax-persitence-api.veresion
>>>
>>> % svn diff pom.xml
>>> Index: pom.xml
>>> ===================================================================
>>> --- pom.xml (revision 26624)
>>> +++ pom.xml (working copy)
>>> @@ -144,7 +144,8 @@
>>> <ucbootstrap.version>0.0.0.15</ucbootstrap.version>
>>> <webservices.version>2.0-b09</webservices.version>
>>> <jaxb.version>2.2-promoted-b17</jaxb.version>
>>> -
>>> <javax-persistence-api.version>2.0.0-M1</javax-persistence-api.version>
>>> +
>>> <javax-persistence-api.version>2.0.0-M2.1</javax-persistence-api.version>
>>>
>>> + <eclipselink.version>2.0.0-M2.1</eclipselink.version>
>>> <dbschema.version>RELEASE60</dbschema.version>
>>> <!-- osgi version string must start with a number. Manually
>>> mapping above dbschema.version to osgi.version here
>>> -->
>>> <dbschema.osgi.version>6.0</dbschema.osgi.version>
>>> % svn diff persistence/eclipselink-wrapper/pom.xml
>>> Index: persistence/eclipselink-wrapper/pom.xml
>>> ===================================================================
>>> --- persistence/eclipselink-wrapper/pom.xml (revision 26624)
>>> +++ persistence/eclipselink-wrapper/pom.xml (working copy)
>>> @@ -47,9 +47,6 @@
>>> <artifactId>eclipselink-wrapper</artifactId>
>>> <packaging>pom</packaging>
>>> <name>Repackaging of EclipseLink as a module</name>
>>> - <properties>
>>> - <eclipselink.version>2.0.0-M1</eclipselink.version>
>>> - </properties>
>>> <developers>
>>> <developer>
>>> <id>mm110999</id>
>>>
>>> Thanks,
>>> Mitesh
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>