dev@glassfish.java.net

Re: [Action] Please review connectors module pom.xml & osgi.bundle

From: Jagadish Prasath Ramu <Jagadish.Ramu_at_Sun.COM>
Date: Fri, 03 Apr 2009 23:28:54 +0530

Hi Marina,
connectors module uses "isCallerInRole(roleName)" from ejbContext.

Sahoo : If we need to avoid dependency on ejb, it has to avoid accessing
ejb api also ?

Thanks,
-Jagadish


On Fri, 2009-04-03 at 10:54 -0700, Marina Vatkina wrote:
> Hi Jagadish,
>
> Can ejbContext implement some interface instead?
>
> thanks,
> -marina
>
> Jagadish Prasath Ramu wrote:
> > In v2, yes, it was actually accessible from component invocation.
> > In v3, as component invocation became generic, this information has been
> > moved to ejb module and hence I had to do it this way.
> >
> > Thanks,
> > -Jagadish
> >
> >
> >
> > On Fri, 2009-04-03 at 23:00 +0530, Sahoo wrote:
> >
> >>Is this not a common problem for any kinds of components accessing the
> >>connection pool? If so, why do you care about ejbContext in particular?
> >>Can't you retrieve the necessary information from a generic object like
> >>ComponentContext?
> >>
> >>Thanks,
> >>Sahoo
> >>
> >>Jagadish Prasath Ramu wrote:
> >>
> >>>Hi Sahoo,
> >>>The functionality [already existing one] that necessitates this is to
> >>>access ejbContext when an ejb component uses a
> >>>connector-connection-pool that has connector-security-map to map the
> >>>appserver principal to EIS principal.
> >>>We get the ejbContext via this container private api.
> >>>
> >>>With Ejbs in .war, I assume it might still be needed ?
> >>>
> >>>Thanks,
> >>>-Jagadish
> >>>
> >>>
> >>>
> >>>
> >>>On Fri, 2009-04-03 at 22:04 +0530, Sahoo wrote:
> >>>
> >>>
> >>>>Jagadish,
> >>>>
> >>>>Although the changes to the files look fine to me, I am a bit concerned
> >>>>about the dependency on ejb module from connectors-runtime. Will that
> >>>>not cause problems if we want to distribute connectors module in a
> >>>>ejb-less distribution? Is this dependency to do with calling MDBs? Can't
> >>>>we avoid this dependency?
> >>>>
> >>>>Thanks,
> >>>>Sahoo
> >>>>
> >>>>Jagadish Prasath Ramu wrote:
> >>>>
> >>>>
> >>>>>Hi Jerome: Jane: Sahoo:
> >>>>>
> >>>>>Please review the pom.xml for connectors-runtime, work-management
> >>>>>and
> >>>>>osgi.bundle for work-management module.
> >>>>>
> >>>>>Please provide your comments by EOD today.
> >>>>>
> >>>>>Thanks,
> >>>>>-Jagadish
> >>>>>
> >>>>>
> >>>>>
> >>>>>Index: v3/connectors/connectors-runtime/pom.xml
> >>>>>===================================================================
> >>>>>--- v3/connectors/connectors-runtime/pom.xml (revision 25867)
> >>>>>+++ v3/connectors/connectors-runtime/pom.xml (working copy)
> >>>>>@@ -136,6 +136,12 @@
> >>>>> <artifactId>work-management</artifactId>
> >>>>> <version>${project.parent.version}</version>
> >>>>> </dependency-->
> >>>>>-
> >>>>>+
> >>>>>+ <dependency>
> >>>>>+ <groupId>org.glassfish.ejb</groupId>
> >>>>>+ <artifactId>ejb-internal-api</artifactId>
> >>>>>+ <version>${project.parent.version}</version>
> >>>>>+ </dependency>
> >>>>>+
> >>>>> </dependencies>
> >>>>> </project>
> >>>>>
> >>>>>
> >>>>>
> >>>>>Index: v3/connectors/work-management/pom.xml
> >>>>>===================================================================
> >>>>>--- v3/connectors/work-management/pom.xml (revision 25864)
> >>>>>+++ v3/connectors/work-management/pom.xml (working copy)
> >>>>>@@ -69,5 +69,11 @@
> >>>>> <version>${project.parent.version}</version>
> >>>>> </dependency>
> >>>>>
> >>>>>+ <dependency>
> >>>>>+ <groupId>org.glassfish.security</groupId>
> >>>>>+ <artifactId>security</artifactId>
> >>>>>+ <version>${project.parent.version}</version>
> >>>>>+ </dependency>
> >>>>>+
> >>>>>
> >>>>>
> >>>>>Index: v3/connectors/work-management/osgi.bundle
> >>>>>===================================================================
> >>>>>--- v3/connectors/work-management/osgi.bundle (revision 25864)
> >>>>>+++ v3/connectors/work-management/osgi.bundle (working copy)
> >>>>>@@ -1,4 +1,5 @@
> >>>>> -exportcontents: \
> >>>>> com.sun.enterprise.connectors.work;\
> >>>>>+ com.sun.enterprise.connectors.work.context;\
> >>>>> com.sun.enterprise.connectors.work.monitor;
> >>>>>version=${project.osgi.version}
> >>>>>
> >>>>>
> >>>>>
> >>>>>
> >>>>>
> >>>>>
> >>>>>
> >>>>>
> >>>>>
> >>>>>---------------------------------------------------------------------
> >>>>>To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> >>>>>For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
> >>>>>
> >>>>>
> >>>>>
> >>>>
> >>>>---------------------------------------------------------------------
> >>>>To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> >>>>For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
> >>>>
> >>>>
> >>>
> >>>
> >>>---------------------------------------------------------------------
> >>>To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> >>>For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
> >>>
> >>>
> >>
> >>---------------------------------------------------------------------
> >>To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> >>For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
> >>
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> > For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>