Jerome,
I understand what you say. I already removed the resources element from
the pom.xml since Maven takes cares of packaging resources with the jar
file when the resources are placed under standard directory structure.
thanks,
Nachiappan
Jerome Dochez wrote:
> Nachi
>
> In general, I prefer not to add things "for the future" as it can have
> undesirable side effects. If someone wants to add .xsd files in the
> future then let the person modify accordingly the pom.xml at that time
> and in a way which fits its use case.
>
> jerome
>
> Nachiappan wrote:
>> Marina Vatkina wrote:
>>> Hi Nachiappan,
>>>
>>> Please make sure you do it for all other checkins as well ;)
>>
>> I have taken care of my other check-in. :-)
>>>
>>> Besides LocalStrings.properties you also listed **/*.xsd resources.
>>> What is the purpose of those?
>> The entry for *.xsd in pom.xml is for adding xml schema files. I am
>> not checking in xml schema resources now. But i am listing that entry
>> in the pom.xml file, if someone has to add any xml schema resources
>> in future.
>>
>> Thanks,
>> Nachiappan
>>
>>
>>>
>>> thanks,
>>> -marina
>>>
>>> Nachiappan wrote:
>>>> Marina Vatkina wrote:
>>>>
>>>>> One more comment on this pom:
>>>>>
>>>>> do we need to keep some of the resources under src/main/java? If
>>>>> they all are under src/main/resources, pom doesn't need to list
>>>>> them explicitly.
>>>>>
>>>> Marina,
>>>>
>>>> After discussion with kedar and sreeni, i understood that we do not
>>>> need to keep the resource (LocalStrings.properties) under
>>>> src/main/java. So I will move the LocalStrings.properties files
>>>> from src/main/java to src/main/resources directory and will update
>>>> the pom.xml file.
>>>>
>>>> Thanks,
>>>> Nachiappan
>>>>
>>>>> thanks,
>>>>> -marina
>>>>>
>>>>> Nachiappan Veerappan Nachiappan wrote:
>>>>>
>>>>>> Hello,
>>>>>>
>>>>>> This is change which i am planning to make to ejb-connector
>>>>>> pom.xml file. In the last email i didn't not add the resources
>>>>>> elements. Sorry about that.
>>>>>>
>>>>>> Thanks,
>>>>>> Nachiappan
>>>>>>
>>>>>> nachi:ejb-connector $ svn diff pom.xml
>>>>>> Index: pom.xml
>>>>>> ===================================================================
>>>>>> --- pom.xml (revision 26497)
>>>>>> +++ pom.xml (working copy)
>>>>>> @@ -58,7 +58,24 @@
>>>>>> <role>lead</role>
>>>>>> </roles>
>>>>>> </developer>
>>>>>> - </developers> + </developers>
>>>>>> + <build>
>>>>>> + <resources>
>>>>>> + <resource>
>>>>>> + <directory>src/main/java</directory>
>>>>>> + <includes>
>>>>>> + <include>**/*.properties</include>
>>>>>> + <include>**/*.xsd</include>
>>>>>> + </includes>
>>>>>> + </resource>
>>>>>> + <resource>
>>>>>> + <directory>src/main/resources</directory>
>>>>>> + <includes>
>>>>>> + <include>**/*.1</include>
>>>>>> + </includes>
>>>>>> + </resource>
>>>>>> + </resources>
>>>>>> + </build> <dependencies>
>>>>>> <dependency>
>>>>>> <groupId>org.glassfish</groupId>
>>>>>> @@ -79,5 +96,22 @@
>>>>>> <groupId>com.sun.enterprise</groupId>
>>>>>> <artifactId>hk2</artifactId>
>>>>>> </dependency>
>>>>>> + <dependency>
>>>>>> + <groupId>org.glassfish.core</groupId>
>>>>>> + <artifactId>kernel</artifactId>
>>>>>> + <version>${project.version}</version>
>>>>>> + <scope>test</scope>
>>>>>> + </dependency>
>>>>>> + <dependency>
>>>>>> + <groupId>org.glassfish.tests</groupId>
>>>>>> + <artifactId>utils</artifactId>
>>>>>> + <version>${project.version}</version>
>>>>>> + <scope>test</scope>
>>>>>> + </dependency>
>>>>>> + <dependency>
>>>>>> + <groupId>org.glassfish.ejb</groupId>
>>>>>> + <artifactId>ejb-internal-api</artifactId>
>>>>>> + <version>${project.version}</version>
>>>>>> + </dependency>
>>>>>> </dependencies>
>>>>>> </project>
>>>>>>
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>>>
>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>