Re: pom.xml for review (javamail)
Peter Williams wrote:
>
>
> Sahoo wrote:
>> The change looks good, but if you can make another change that will
>> be better.
>>
>> Add javax.mail dependency under <dependencyManagement> in v3/pom.xml
>> so that you don't have to specify the version in javax.mail/pom.xml
>> and there by the version information is not scattered.
>
> Ok, that makes sense. Given the lateness of the hour, I'd prefer to
> make the improvement you suggest as an MS3 task. If I understand what
> you are suggesting, it will merely make the build more maintainable,
> but not actually change anything in how it works and thus is not
> required for MS2.
>
> Since I've already performed all testing on the change I submitted, I
> don't know that there is time to redo that effort before the midnight
> deadline and it does not seem to be necessary.
>
> So I will check this change in as-is for MS2 and as soon as the
> repository is open for MS3 commits, I'll resubmit with the dependency
> change you are suggesting.
OK, sounds good to me.
Thanks,
Sahoo
>
> -Peter
>
>>
>> Thanks,
>> Sahoo
>>
>> Peter Williams wrote:
>>> Hi,
>>>
>>> I need to upgrade the javamail version in V3 to JavaMail 1.4.2. For
>>> MS2, we will use the 1.4.2 jar published on java.net.
>>>
>>> Please review the attached pom.xml changes that do this (1 line each
>>> in v3/pom.xml and v3/javaee-api/mail/pom.xm) and let me know I can
>>> commit the changes.
>>>
>>> Quicklook passes.
>>>
>>> Thanks
>>> -Peter
>>> ------------------------------------------------------------------------
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>