Hi Hong,
I just noticed that (at least on Windows) you can use a comma in a
directory name.
Therefore, on second thought, another separator would be better.
Would it be too late to use a colon or semicolon (the OS's path
separator) instead of a colon?
I'll raise an issue about it.
Regards,
Dies
Hong Zhang wrote:
> Hi, Dies
>> If fixing this is as easy as updating those three places and
>> reassigning the issue to the docs team I can do it. Assuming you agree
>> with the suggestion of course.
> I think it is a good idea to explicitly put the "," in the usage text,
> thanks for bringing it up! I am not too familiar with this part as this
> part used to be owned by cli team. But we can start with the three
> places you pointed out..
>
> Thanks,
>
> - Hong
>> dkoper_at_dev.java.net wrote:
>>> https://glassfish.dev.java.net/issues/show_bug.cgi?id=7895
>>> Issue #|7895
>>> Summary|--libraries option's unusual path separator
>>> Component|glassfish
>>> Version|V3
>>> Platform|All
>>> OS/Version|All
>>> URL|
>>> Status|UNCONFIRMED
>>> Status whiteboard|
>>> Keywords|
>>> Resolution|
>>> Issue type|DEFECT
>>> Priority|P3
>>> Subcomponent|deployment
>>> Assigned to|hzhang_jn
>>> Reported by|dkoper
>>>
>>>
>>>
>>>
>>>
>>>
>>> ------- Additional comments from dkoper_at_dev.java.net Fri Apr 17
>>> 00:04:08 +0000 2009 -------
>>> asadmin's deploy subcommand gives the following usage for the
>>> --libraries option:
>>>
>>> [--libraries jar_file[(pathseparator)jar_file]*]
>>>
>>> Say "pathseparator" to a Java developer and (s)he thinks of ; or :
>>> depending on
>>> the OS.
>>>
>>> A comma is the last delimiter one would expect.
>>> http://en.wikipedia.org/wiki/Path_(computing)
>>>
>>> Although it is explained in the --help if you look it up, why not
>>> make it clear
>>> from the start in the Usage text?
>>> [--libraries jar_file[,jar_file]*]
>>>
>>> Same for deploydir subcommand:
>>>
>>> /GFv3/admin_cli_java/com/sun/enterprise/admin/cli/remote/LocalStrings.properties
>>>
>>> /GFv3/deployment_admin_java/org/glassfish/deployment/admin/LocalStrings.properties
>>>
>>> (2 places)
>>