Re: please approve AMX, JSR 77 pom.xml additions, changes

From: Lloyd Chambers <Lloyd.Chambers_at_Sun.COM>
Date: Thu, 16 Apr 2009 15:50:51 -0700

Jane,

Thanks, I'll try this, but I had thought I saw an issue where the
transitivity failed, and I had to insert the dependencies.

I'll try again.

Lloyd

On Apr 16, 2009, at 3:42 PM, Jane Young wrote:

> Hi Lloyd,
>
> common/pom.ml -- looks fine
> common/amx-core/pom.xml -- looks fine
> common/amx-core-impl/pom.xml -- common-util already has
> dependencies on glassfish-api and hk2 so no need to define them.
> common/amx-config/pom.xml -- amx-core has a depdency on glassfish-
> api so no need to define that
> common/amx-config-impl/pom.xml -- same comments relating to
> transitive dependencies.
> common/amx-ext-impl/pom.xml -- same comments relating to transitive
> dependencies
> common/amx-j2ee/pom.xml -- amx-core already has a dependency on
> glassfish-api
> common/amx-j2ee-impl/pom.xml -- same comments relating to
> transitive depdencies
> common/mejb/pom.xml -- looks good
>
> Jane
>
>
> Lloyd Chambers wrote:
>>
>> Jane et al,
>>
>> I'm ready to commit the following new modules and pom.xml changes.
>> QuickLook passes 61/61.
>>
>> As a first step, I ant to commit these modules *without* modifying
>> the distribution. That way, the code is in and building, and if
>> there's any problem with the distribution it's a separate issue.
>>
>> Modules with a "**" after them indicate ones to be included in the
>> glassfish.zip distribution only, because they require ejb.
>>
>> common/amx-core
>> common/amx-core-impl
>> common/amx-config
>> common/amx-config-impl
>> common/amx-ext-impl
>>
>> Modules only for 'glassfish' distribution:
>> common/amx-j2ee **
>> common/amx-j2ee-impl **
>> common/mejb **
>>
>> Please note that *after a transition period*, the existing amx-api
>> and amx-impl modules will be *removed*.
>>
>> Here are the pom.xml files (headers comments omitted):
>>
>>
>> llcMP:common llc$ svn diff pom.xml
>> Index: pom.xml
>> ===================================================================
>> --- pom.xml (revision 26264)
>> +++ pom.xml (working copy)
>> @@ -49,9 +49,19 @@
>> <packaging>pom</packaging>
>> <name>GlassFish Common modules</name>
>> <modules>
>> - <module>stats77</module>
>> <module>glassfish-api</module>
>> <module>mbeanserver</module>
>> +
>> + <module>stats77</module>
>> + <module>amx-core</module>
>> + <module>amx-core-impl</module>
>> + <module>amx-config</module>
>> + <module>amx-config-impl</module>
>> + <module>amx-j2ee</module>
>> + <module>amx-j2ee-impl</module>
>> + <module>amx-ext-impl</module>
>> + <module>mejb</module>
>> +
>> <module>amx-api</module>
>> <module>amx-impl</module>
>> <module>glassfish-ee-api</module>
>>
>>
>> llcMP:common llc$ cat amx-core/pom.xml
>> <?xml version="1.0" encoding="UTF-8"?>
>> <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance
>> "
>> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd
>> ">
>> <parent>
>> <groupId>org.glassfish.common</groupId>
>> <artifactId>common</artifactId>
>> <version>3.0-SNAPSHOT</version>
>> </parent>
>> <modelVersion>4.0.0</modelVersion>
>> <artifactId>amx-core</artifactId>
>> <packaging>hk2-jar</packaging>
>> <name>AMX V3 Core</name>
>> <description>Appserver Management Extensions (AMX) Core</
>> description>
>>
>> <developers>
>> <developer>
>> <id>llc</id>
>> <name>Lloyd Chambers</name>
>> <url>http://blogs.sun.com/lchambers</url>
>> <organization>Sun Microsystems, Inc.</organization>
>> <roles>
>> <role>lead</role>
>> <role>developer</role>
>> </roles>
>> </developer>
>> </developers>
>>
>> <dependencies>
>> <dependency>
>> <groupId>org.glassfish.common</groupId>
>> <artifactId>glassfish-api</artifactId>
>> <version>${project.version}</version>
>> </dependency>
>>
>> <dependency>
>> <groupId>org.glassfish.common</groupId>
>> <artifactId>glassfish-mbeanserver</artifactId>
>> <version>${project.version}</version>
>> </dependency>
>>
>> <dependency>
>> <groupId>org.glassfish.common</groupId>
>> <artifactId>amx-util</artifactId>
>> <version>${project.version}</version>
>> </dependency>
>>
>> </dependencies>
>> </project>
>> llcMP:common llc$
>>
>>
>>
>> llcMP:common llc$ cat amx-core-impl/pom.xml
>> <?xml version="1.0" encoding="UTF-8"?>
>> <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance
>> "
>> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd
>> ">
>> <parent>
>> <groupId>org.glassfish.common</groupId>
>> <artifactId>common</artifactId>
>> <version>3.0-SNAPSHOT</version>
>> </parent>
>> <modelVersion>4.0.0</modelVersion>
>> <artifactId>amx-core-impl</artifactId>
>> <packaging>hk2-jar</packaging>
>> <name>AMX V3 Core implementation</name>
>> <description>Implementation of core AMX APIs</description>
>>
>> <developers>
>> <developer>
>> <id>llc</id>
>> <name>Lloyd Chambers</name>
>> <url>http://blogs.sun.com/lchambers</url>
>> <organization>Sun Microsystems, Inc.</organization>
>> <roles>
>> <role>lead</role>
>> <role>developer</role>
>> </roles>
>> </developer>
>> </developers>
>>
>> <build>
>> <resources>
>> <resource>
>> <directory>src/main/java</directory>
>> <includes>
>> <include>org/glassfish/admin/amx/cmd/
>> *.properties</include>
>> <include>org/glassfish/admin/amx/dotted/
>> *.properties</include>
>> </includes>
>> </resource>
>> </resources>
>> </build>
>>
>>
>> <dependencies>
>> <dependency>
>> <groupId>com.sun.enterprise</groupId>
>> <artifactId>hk2</artifactId>
>> </dependency>
>>
>> <dependency>
>> <groupId>org.glassfish.common</groupId>
>> <artifactId>amx-core</artifactId>
>> <version>${project.version}</version>
>> </dependency>
>>
>> <dependency>
>> <groupId>org.glassfish.common</groupId>
>> <artifactId>glassfish-mbeanserver</artifactId>
>> <version>${project.version}</version>
>> </dependency>
>>
>> <dependency>
>> <groupId>org.glassfish.common</groupId>
>> <artifactId>common-util</artifactId>
>> <version>${project.version}</version>
>> </dependency>
>>
>> <dependency>
>> 
>> <groupId>org.glassfish.common</groupId>
>> <artifactId>glassfish-api</artifactId>
>> </dependency>
>>
>> <dependency>
>> <groupId>org.glassfish.common</groupId>
>> <artifactId>internal-api</artifactId>
>> <version>${project.version}</version>
>> </dependency>
>>
>> <dependency>
>> <groupId>org.glassfish.tests</groupId>
>> <artifactId>utils</artifactId>
>> <version>${project.version}</version>
>> <scope>test</scope>
>> </dependency>
>>
>> </dependencies>
>> </project>
>> llcMP:common llc$
>>
>>
>>
>>
>> llcMP:common llc$ cat amx-config/pom.xml
>> <?xml version="1.0" encoding="UTF-8"?>
>> <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance
>> "
>> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd
>> ">
>> <parent>
>> <groupId>org.glassfish.common</groupId>
>> <artifactId>common</artifactId>
>> <version>3.0-SNAPSHOT</version>
>> </parent>
>> <modelVersion>4.0.0</modelVersion>
>> <artifactId>amx-config</artifactId>
>> <packaging>hk2-jar</packaging>
>> <name>AMX V3 Config</name>
>> <description>AMX Config interfaces</description>
>>
>> <developers>
>> <developer>
>> <id>llc</id>
>> <name>Lloyd Chambers</name>
>> <url>http://blogs.sun.com/lchambers</url>
>> <organization>Sun Microsystems, Inc.</organization>
>> <roles>
>> <role>lead</role>
>> <role>developer</role>
>> </roles>
>> </developer>
>> </developers>
>>
>> <dependencies>
>> <dependency>
>> <groupId>org.glassfish.common</groupId>
>> <artifactId>glassfish-api</artifactId>
>> <version>${project.version}</version>
>> </dependency>
>>
>> <dependency>
>> <groupId>org.glassfish.common</groupId>
>> <artifactId>amx-core</artifactId>
>> <version>${project.version}</version>
>> </dependency>
>>
>> </dependencies>
>> </project>
>>
>>
>>
>>
>> llcMP:common llc$ cat amx-config-impl/pom.xml
>> <?xml version="1.0" encoding="UTF-8"?>
>> 
>> </dependency>
>>
>>
>> <dependency>
>> <groupId>org.glassfish.common</groupId>
>> <artifactId>amx-core</artifactId>
>> <version>${project.version}</version>
>> </dependency>
>>
>> </dependencies>
>> </project>
>>
>>
>>
>>
>>
>>
>>
>

Lloyd Chambers
lloyd.chambers_at_sun.com
GlassFish Team