dev@glassfish.java.net

Re: please review pom.xml changes for JSR 77 module

From: Lloyd Chambers <Lloyd.Chambers_at_Sun.COM>
Date: Thu, 09 Apr 2009 12:27:40 -0700

Sahoo,

Inline...

On Apr 9, 2009, at 12:24 PM, Sahoo wrote:

> See comments inline...
>
> Lloyd Chambers wrote:
>> Sahoo,
>>
>> Sorry, too many poms, I edited the wrong one!
>>
>> Lloyd
>>
> Before checking in, add license header and copyright information.
>> <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance
>> "
>> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd
>> ">
>> <parent>
>> <groupId>org.glassfish</groupId>
>> <artifactId>api-pom</artifactId>
>> <version>3.0-SNAPSHOT</version>
>> </parent>
>>
>> <modelVersion>4.0.0</modelVersion>
>> <artifactId>jsr77</artifactId>
> Change the above line to:
> <artifactId>javax.management.j2ee</artifactId>

OK

>
>
> Moreover, rename the directory containing this pom.xml to
> javax.management.j2ee, which means commons/pom.xml will have a new
> module called javax.management.j2ee.
OK

>
>> <packaging>jar</packaging>
>> <properties>
>> <extension.name>javax.management.j2ee</extension.name>
>> <spec.version>1.1</spec.version>
>> </properties>
>> <name>${extension.name} API v.${spec.version}</name>
>> <url>http://jcp.org/en/jsr/detail?id=77</url>
>>
>> <developers>
>> <developer>
>> <id>llc</id>
>> <name>Lloyd Chambers</name>
>> <url>http://blogs.sun.com/lchambers</url>
>> <organization>Sun Microsystems, Inc.</organization>
>> <roles>
>> <role>lead</role>
>> <role>developer</role>
>> </roles>
>> </developer>
>> </developers>
>>
>> <dependencies>
>>
>> <dependency>
>> <groupId>org.glassfish.common</groupId>
>> <artifactId>stats77</artifactId>
>> <version>${project.version}</version>
>> </dependency>
> Why is this dependency needed? This was not there when you sent the
> POM first time for review, was this? Did you edit the wrong file
> again?
No, this is correct. We have another module in which we implement
Stats and Statistics, which we need to use without relying on JSR 77
itself.

Jerome is on board with this, but if you think it's a problem....?


>
>
> Thanks,
> Sahoo
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>

Lloyd Chambers
lloyd.chambers_at_sun.com
GlassFish Team