Wow, FindBugs errors went to zero and no one noticed? Are you sure the
report is correct?
Rather than going deeper, I'd suggest going broader. Nearly every high
priority error is a real bug. Many of the medium priority errors require
more analysis and judgment to determine whether they're really errors.
The "developer report" only addresses a subset of all the code in GlassFish.
The "fancy report" (which is using FindBugs 1.3.6-rc1) still shows lots of
high priority issues. No doubt some of them are in code that we don't
touch, and so should be excluded. But the rest should be addressed.
And isn't it past time to integrate these two reports, possibly using the
Hudson FindBugs plugin?
Jagadesh Babu Munta wrote:
> Hi Vince,
> Thanks for sharing the information.
>
> Yes. If all bugs are gone way, we can go to the medium bugs.
> Good idea.
>
> I will be checking the results if indeed the case or any other issue.
> Based on that we can enable for Medium priority also.
>
> Thanks.
> -- Jagadesh
>
>
> Vince Kraemer wrote:
>> that there is a job that automatically checks our v3 code with
>> FindBugs every day for high priority issues?
>> *https://glassfish.dev.java.net/quality/v3/fb-developer-report.html
>>
>> *Did you know that we have been keeping clean for quite some time?
>> You can see the history of the file here:
>> http://fisheye5.atlassian.com/browse/glassfish/www/quality/v3/fb-developer-report.html
>>
>>
>> So, should we 'double down' and start getting a report that includes
>> High and Medium priority issues generated?
>>
>> You can go here to see a list of the bugs FindBugs finds here:
>> http://findbugs.sourceforge.net/bugDescriptions.html
>>
>> vbk
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net