Hi Jane,

I just committed a fix that should turn QL green again.

However, I've been unable to reproduce the QL failure locally.
I was able to pinpoint the issue only by looking one of our unit
test failures.

When I run QL (on the web or glassfish distro), I've been getting
50 passes and 0 failures:

   [testng] ===============================================
   [testng] QuickLookTests
   [testng] Total tests run: 50, Failures: 0, Skips: 0
   [testng] ===============================================

even with my commit from yesterday that caused QL to start to fail.

I think the reason I did not notice the regression is that I am running only
50 tests, while the Hudson job shows 56 test cases.

I should probably know this, but what do I need to do to run all 56 tests?
My QL ws is up-to-date.

Thanks to you and Anissa, and sorry for causing the trouble!

Jan

On 03/17/09 08:44 AM, Jane Young wrote:

Hi Jason,

Thanks for looking into this.  I think jleuhe's checkin (r25431) is the culprit to admin console failure.    When I revert his changes from my local workspace, admin  console works.

Jan, if you see this, can you take a look at this issue?

Thanks,
Jane


Jason Lee wrote:

Here's what I'm seeing.  After I did our branch-to-trunk merge, I ran the QL tests -- a lot -- and had no failure.  After I committed, I checked out a fresh tree, built it and ran QL with no errors.  This morning,  not having updated my tree since my commit, I tested the console just to confirm that things were working, which they were.  Next, I updated all the modules in my tree and tested the console, which no longer worked.  It looks like the browser is alternating between login.jsf and the app's home page.  On a whim, I disable security for the console, rebuilt the entire server and "installed" it, and the console worked.  I did, though, get the odd errors below in the server log.  I'm not sure what they mean yet, though...

[#|2009-03-17T09:52:11.301-0500|INFO|glassfish|global|_ThreadID=16;_ThreadName=Thread-1;|The Admin Console application is loaded.|#]

[#|2009-03-17T09:52:22.788-0500|INFO|glassfish|org.jvnet.hk2.osgiadapter|_ThreadID=19;_ThreadName=Thread-1;org.glassfish.common.amx-impl [69];|Started bundle org.glassfish.common.amx-impl [69]|#]

[#|2009-03-17T09:52:24.259-0500|INFO|glassfish|javax.enterprise.system.tools.admin|_ThreadID=19;_ThreadName=Thread-1;|AMXStartupService: loaded 138 AMX MBeans in 1358 ms (wall-clock time)|#]

[#|2009-03-17T09:52:40.045-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;|java.lang.reflect.InvocationTargetException|#]

[#|2009-03-17T09:52:40.046-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;| at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)|#]

[#|2009-03-17T09:52:40.046-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;| at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)|#]

[#|2009-03-17T09:52:40.047-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;| at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)|#]

[#|2009-03-17T09:52:40.048-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;| at java.lang.reflect.Method.invoke(Method.java:597)|#]

[#|2009-03-17T09:52:40.048-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;| at com.sun.faces.extensions.avatar.lifecycle.AsyncResponse.createAjaxResponseWriter(AsyncResponse.java:349)|#]

[#|2009-03-17T09:52:40.055-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;| at com.sun.faces.extensions.avatar.lifecycle.AsyncResponse.getResponseWriter(AsyncResponse.java:105)|#]

[#|2009-03-17T09:52:40.055-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;| at com.sun.faces.extensions.avatar.components.PartialTraversalViewRootHelper.encodeBegin(PartialTraversalViewRootHelper.java:327)|#]

[#|2009-03-17T09:52:40.056-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;| at com.sun.faces.extensions.avatar.components.PartialTraversalViewRootImpl.encodeBegin(PartialTraversalViewRootImpl.java:168)|#]

[#|2009-03-17T09:52:40.056-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;| at com.sun.jsftemplating.layout.descriptors.LayoutDefinition.encode(LayoutDefinition.java:222)|#]

[#|2009-03-17T09:52:40.057-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;| at com.sun.jsftemplating.layout.LayoutViewHandler.renderView(LayoutViewHandler.java:673)|#]

[#|2009-03-17T09:52:40.057-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;| at com.sun.faces.lifecycle.RenderResponsePhase.execute(RenderResponsePhase.java:97)|#]

[#|2009-03-17T09:52:40.058-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;| at com.sun.faces.lifecycle.Phase.doPhase(Phase.java:102)|#]

[#|2009-03-17T09:52:40.058-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;| at com.sun.faces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:139)|#]

[#|2009-03-17T09:52:40.059-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;| at com.sun.faces.extensions.avatar.lifecycle.PartialTraversalLifecycle.render(PartialTraversalLifecycle.java:107)|#]

[#|2009-03-17T09:52:40.059-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;| at javax.faces.webapp.FacesServlet.service(FacesServlet.java:311)|#]

[#|2009-03-17T09:52:40.059-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;| at org.apache.catalina.core.ApplicationFilterChain.servletService(ApplicationFilterChain.java:465)|#]

[#|2009-03-17T09:52:40.060-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;| at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:358)|#]

[#|2009-03-17T09:52:40.060-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;| at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:226)|#]

[#|2009-03-17T09:52:40.061-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;| at com.sun.webui.jsf.util.UploadFilter.doFilter(UploadFilter.java:267)|#]

[#|2009-03-17T09:52:40.061-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;| at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:271)|#]

[#|2009-03-17T09:52:40.062-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;| at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:226)|#]

[#|2009-03-17T09:52:40.062-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;| at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:300)|#]

[#|2009-03-17T09:52:40.062-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;| at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:187)|#]

[#|2009-03-17T09:52:40.070-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;| at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:656)|#]

[#|2009-03-17T09:52:40.071-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;| at com.sun.enterprise.web.WebPipeline.invoke(WebPipeline.java:97)|#]

[#|2009-03-17T09:52:40.071-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;| at com.sun.enterprise.web.PESessionLockingStandardPipeline.invoke(PESessionLockingStandardPipeline.java:98)|#]

[#|2009-03-17T09:52:40.072-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;| at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:185)|#]

[#|2009-03-17T09:52:40.073-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;| at org.apache.catalina.connector.CoyoteAdapter.doService(CoyoteAdapter.java:352)|#]

[#|2009-03-17T09:52:40.073-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;| at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:250)|#]

[#|2009-03-17T09:52:40.074-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;| at com.sun.enterprise.v3.services.impl.ContainerMapper.service(ContainerMapper.java:208)|#]

[#|2009-03-17T09:52:40.075-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;| at com.sun.grizzly.http.ProcessorTask.invokeAdapter(ProcessorTask.java:659)|#]

[#|2009-03-17T09:52:40.080-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;| at com.sun.grizzly.http.ProcessorTask.doProcess(ProcessorTask.java:577)|#]

[#|2009-03-17T09:52:40.083-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;| at com.sun.grizzly.http.ProcessorTask.process(ProcessorTask.java:829)|#]

[#|2009-03-17T09:52:40.083-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;| at com.sun.grizzly.http.DefaultProtocolFilter.execute(DefaultProtocolFilter.java:162)|#]

[#|2009-03-17T09:52:40.084-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;| at com.sun.enterprise.v3.services.impl.GlassfishProtocolChain.executeProtocolFilter(GlassfishProtocolChain.java:71)|#]

[#|2009-03-17T09:52:40.084-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;| at com.sun.grizzly.DefaultProtocolChain.execute(DefaultProtocolChain.java:103)|#]

[#|2009-03-17T09:52:40.084-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;| at com.sun.grizzly.DefaultProtocolChain.execute(DefaultProtocolChain.java:89)|#]

[#|2009-03-17T09:52:40.100-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;| at com.sun.grizzly.http.HttpProtocolChain.execute(HttpProtocolChain.java:76)|#]

[#|2009-03-17T09:52:40.101-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;| at com.sun.grizzly.ProtocolChainContextTask.doCall(ProtocolChainContextTask.java:67)|#]

[#|2009-03-17T09:52:40.102-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;| at com.sun.grizzly.SelectionKeyContextTask.call(SelectionKeyContextTask.java:57)|#]

[#|2009-03-17T09:52:40.128-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;| at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)|#]

[#|2009-03-17T09:52:40.129-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;| at java.util.concurrent.FutureTask.run(FutureTask.java:138)|#]

[#|2009-03-17T09:52:40.129-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;| at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:885)|#]

[#|2009-03-17T09:52:40.130-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;| at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:907)|#]

[#|2009-03-17T09:52:40.136-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;| at java.lang.Thread.run(Thread.java:637)|#]

[#|2009-03-17T09:52:40.140-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;|Caused by: java.lang.IllegalStateException: PWC3991: getOutputStream() has already been called for this response|#]

[#|2009-03-17T09:52:40.140-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;| at org.apache.catalina.connector.Response.getWriter(Response.java:723)|#]

[#|2009-03-17T09:52:40.141-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;| at org.apache.catalina.connector.ResponseFacade.getWriter(ResponseFacade.java:232)|#]

[#|2009-03-17T09:52:40.146-0500|SEVERE|glassfish|null|_ThreadID=15;_ThreadName=Thread-1;| ... 45 more|#]

[#|2009-03-17T09:52:40.624-0500|SEVERE|glassfish|javax.enterprise.system.container.web|_ThreadID=15;_ThreadName=Thread-1;|StandardWrapperValve[FacesServlet]: PWC1406: Servlet.service() for servlet FacesServlet threw exception

java.lang.NullPointerException: Argument Error: Parameter responseWriter is null

at com.sun.faces.util.Util.notNull(Util.java:223)

at com.sun.faces.context.FacesContextImpl.setResponseWriter(FacesContextImpl.java:464)

at com.sun.faces.extensions.avatar.components.PartialTraversalViewRootHelper.encodeBegin(PartialTraversalViewRootHelper.java:335)

at com.sun.faces.extensions.avatar.components.PartialTraversalViewRootImpl.encodeBegin(PartialTraversalViewRootImpl.java:168)

at com.sun.jsftemplating.layout.descriptors.LayoutDefinition.encode(LayoutDefinition.java:222)

at com.sun.jsftemplating.layout.LayoutViewHandler.renderView(LayoutViewHandler.java:673)

at com.sun.faces.lifecycle.RenderResponsePhase.execute(RenderResponsePhase.java:97)

at com.sun.faces.lifecycle.Phase.doPhase(Phase.java:102)

at com.sun.faces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:139)

at com.sun.faces.extensions.avatar.lifecycle.PartialTraversalLifecycle.render(PartialTraversalLifecycle.java:107)

at javax.faces.webapp.FacesServlet.service(FacesServlet.java:311)

at org.apache.catalina.core.ApplicationFilterChain.servletService(ApplicationFilterChain.java:465)

at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:358)

at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:226)

at com.sun.webui.jsf.util.UploadFilter.doFilter(UploadFilter.java:267)

at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:271)

at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:226)

at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:300)

at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:187)

at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:656)

at com.sun.enterprise.web.WebPipeline.invoke(WebPipeline.java:97)

at com.sun.enterprise.web.PESessionLockingStandardPipeline.invoke(PESessionLockingStandardPipeline.java:98)

at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:185)

at org.apache.catalina.connector.CoyoteAdapter.doService(CoyoteAdapter.java:352)

at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:250)

at com.sun.enterprise.v3.services.impl.ContainerMapper.service(ContainerMapper.java:208)

at com.sun.grizzly.http.ProcessorTask.invokeAdapter(ProcessorTask.java:659)

at com.sun.grizzly.http.ProcessorTask.doProcess(ProcessorTask.java:577)

at com.sun.grizzly.http.ProcessorTask.process(ProcessorTask.java:829)

at com.sun.grizzly.http.DefaultProtocolFilter.execute(DefaultProtocolFilter.java:162)

at com.sun.enterprise.v3.services.impl.GlassfishProtocolChain.executeProtocolFilter(GlassfishProtocolChain.java:71)

at com.sun.grizzly.DefaultProtocolChain.execute(DefaultProtocolChain.java:103)

at com.sun.grizzly.DefaultProtocolChain.execute(DefaultProtocolChain.java:89)

at com.sun.grizzly.http.HttpProtocolChain.execute(HttpProtocolChain.java:76)

at com.sun.grizzly.ProtocolChainContextTask.doCall(ProtocolChainContextTask.java:67)

at com.sun.grizzly.SelectionKeyContextTask.call(SelectionKeyContextTask.java:57)

at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)

at java.util.concurrent.FutureTask.run(FutureTask.java:138)

at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:885)

at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:907)

at java.lang.Thread.run(Thread.java:637)

|#]

On Mar 16, 2009, at 6:11 PM, Jane Young wrote:

Thank you, Anissa!


Anissa Lam wrote:

My admingui code is the latest, but other modules are not,  and i don't see the problem.   I will update my workspace and look into that.

thanks

Anissa.

Jane Young wrote:

Hi,

Can someone from Admin Console team take a look at the QL tests with the glassfish distribution?

I'm seeing:

 [testng] ***** Login page not found.  Sleeping to allow app to deploy (57 of 60)...

 [testng] ***** Login page not found.  Sleeping to allow app to deploy (58 of 60)...

 [testng] ***** Login page not found.  Sleeping to allow app to deploy (59 of 60)...

 [testng] ***** Login page not found.  Sleeping to allow app to deploy (60 of 60)...

 [testng] FAILED CONFIGURATION: @BeforeTest loginBeforeTest("http://localhost:4848/", 8686)

 [testng] java.lang.AssertionError: The login form was not found.

 [testng]     at test.admin.BaseAdminConsoleTest.loginBeforeTest(BaseAdminConsoleTest.java:121)

 [testng] ... Removed 20 stack frames

 [testng] FAILED: testDeployedWebAppPage

 [testng] java.lang.AssertionError: The Deployed Web Applications table does not appear to have bee\

n rendered. expected:<true> but was:<false>

 [testng]     at test.admin.AdminConsoleTests.testDeployedWebAppPage(AdminConsoleTests.java:53)

 [testng] ... Removed 25 stack frames

 [testng] FAILED: testCommonTasks

 [testng] java.lang.AssertionError: The Common Task page does not appear to have been rendered. exp\

ected:<true> but was:<false>

 [testng]     at test.admin.AdminConsoleTests.testCommonTasks(AdminConsoleTests.java:42)

 [testng] ... Removed 25 stack frames

 [testng] FAILED: testHelpPage

 [testng] java.lang.AssertionError: expected:<true> but was:<false>

 [testng]     at test.admin.AdminConsoleTests.testHelpPage(AdminConsoleTests.java:60)

 [testng] ... Removed 26 stack frames

 [testng]

This is from my local workspace using today's build.

You can also see the QL failures here :  http://hudson.glassfish.org/job/gfv3-build-test/

Jane

---------------------------------------------------------------------

To unsubscribe, e-mail: dev-unsubscribe@glassfish.dev.java.net

For additional commands, e-mail: dev-help@glassfish.dev.java.net

---------------------------------------------------------------------

To unsubscribe, e-mail: dev-unsubscribe@glassfish.dev.java.net

For additional commands, e-mail: dev-help@glassfish.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@glassfish.dev.java.net
For additional commands, e-mail: dev-help@glassfish.dev.java.net

Jason Lee Senior Java Developer GlassFish Administration Console Sun Microsystems, Inc. Phone x31197/+1 405-343-1964 Email jasondlee@sun.com Blog http://blogs.sun.com/jasondlee Blog http://blogs.steeplesoft.com

---

Subject: svn commit: r25431 - trunk/v3/web/web-glue/src/main/java/com/sun/enterprise/web/TomcatDeploymentConfig.java

From: jluehe@dev.java.net

Date: Mon, 16 Mar 2009 20:41:36 +0000

To: commits@glassfish-svn.dev.java.net

To: commits@glassfish-svn.dev.java.net

Author: jluehe
Date: 2009-03-16 20:41:21+0000
New Revision: 25431

Modified:
   trunk/v3/web/web-glue/src/main/java/com/sun/enterprise/web/TomcatDeploymentConfig.java

Log:
Propagate <session-config><tracking-mode> from web.xml to context

Tests run: QL

Modified: trunk/v3/web/web-glue/src/main/java/com/sun/enterprise/web/TomcatDeploymentConfig.java
Url: https://glassfish-svn.dev.java.net/source/browse/glassfish-svn/trunk/v3/web/web-glue/src/main/java/com/sun/enterprise/web/TomcatDeploymentConfig.java?view=diff&rev=25431&p1=trunk/v3/web/web-glue/src/main/java/com/sun/enterprise/web/TomcatDeploymentConfig.java&p2=trunk/v3/web/web-glue/src/main/java/com/sun/enterprise/web/TomcatDeploymentConfig.java&r1=25430&r2=25431
==============================================================================
--- trunk/v3/web/web-glue/src/main/java/com/sun/enterprise/web/TomcatDeploymentConfig.java	(original)
+++ trunk/v3/web/web-glue/src/main/java/com/sun/enterprise/web/TomcatDeploymentConfig.java	2009-03-16 20:41:21+0000
@@ -758,9 +758,10 @@
             }
         }
        
-        // <session-config>
         SessionConfigDescriptor sessionConfigDesc = 
             wmd.getSessionConfigDescriptor();
+
+        // <session-config><session-timeout>
         webModule.setSessionTimeout(sessionConfigDesc.getSessionTimeout());
 
         // <session-config><cookie-config>
@@ -778,6 +779,9 @@
             cookieConfig.setMaxAge(cookieConfigDesc.getMaxAge());
         }
 
+        // <session-config><tracking-mode>
+        webModule.setSessionTrackingModes(sessionConfigDesc.getTrackingModes());
+
         enumeration = wmd.getWelcomeFiles();
         while (enumeration.hasMoreElements()){
             webModule.addWelcomeFile((String)enumeration.nextElement());

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@glassfish-svn.dev.java.net
For additional commands, e-mail: commits-help@glassfish-svn.dev.java.net


  

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@glassfish.dev.java.net
For additional commands, e-mail: dev-help@glassfish.dev.java.net