Hi Anissa,
Anissa Lam wrote:
> Hi Marina,
>
> I don't think i agree with you.
> If there is QL failure in say 'admin' or 'security' or 'web
> container', do you remove that or comment out that part of
> quicklook ? Why Admin Console should be different ?
You are expected not to check in the code that breaks the QL, right?
>
> Your saying of : *'a QL that is guarantee to report failures' *is
> not true at all.
>
> It reports failure because there is a regression in the system. If
> we were able to turn on the QL yesterday, then someone will see that
> whatever the change they put in is causing Admin Console to fail and
> we can avoid this .
Agree. Where I disagree, is the point of adding a test *before* it can
pass.
> This is what QL is for.
Yes.
thanks,
-marina
>
> thanks
> Anissa
>
>
> Marina Vatkina wrote:
>> Anissa Lam wrote:
>>>
>>> I will say no. Why do you want to turn off the test ?
>>
>> So that others can easily see if they cause any regressions?
>>
>>
>> It is a valid
>>> test and the system is indeed has problem. There is no way to bring
>>> up the admin console now.
>>
>> That's why we have an open bug. But having a QL that is guarantee to
>> report failures is very confusing...
>>
>> thanks,
>> -marina
>>
>> Jan is looking into the issue and think that
>>> may be related to the Grizzly integration.
>>>
>>> thanks
>>> Anissa.
>>>
>>> Marina Vatkina wrote:
>>>
>>>> Anissa,
>>>>
>>>> Can we turn off Admin Console QL until you find the fix?
>>>>
>>>> thanks,
>>>> -marina
>>>>
>>>> Anissa Lam wrote:
>>>>
>>>>>
>>>>> Thanks to Jason, Admin Console QL is now turned on. If you
>>>>> update your workspace, your QL run will also include admin
>>>>> console QL.
>>>>> As of now, admin console QL is failing because there is problem
>>>>> in the system. We can't access the login page and thus cannot
>>>>> bring up the console. It sure does the job :)
>>>>>
>>>>> An issue has been filed,
>>>>> https://glassfish.dev.java.net/issues/show_bug.cgi?id=6131
>>>>> Hopefully we will be able to catch this kind of issue sooner now
>>>>> that the test is in place.
>>>>>
>>>>> thanks
>>>>> Anissa.
>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net For
> additional commands, e-mail: dev-help_at_glassfish.dev.java.net