dev@glassfish.java.net

Re: quicklook changed? Not working

From: Sahoo <Sahoo_at_Sun.COM>
Date: Mon, 08 Sep 2008 22:52:47 +0530

Why can't the test simply use its own copy of
jsftemplating-dynafaces-0.1.jar instead of referring to maven local
repo? It will be much more reliable that way. QL can't assume that
user's local repo has such an artifact, can it?

Thanks,
Sahoo

Lloyd Chambers wrote:
> Ming,
>
> Thanks. I suppose this option can also be added to MVN_OPTS?
>
> MVN_OPTS="-D-Xmx512M -Dmaven.repo.local=/v3/run"
>
> ?
>
> I found that an easier workaround (one I don't have to remember to use
> each time) is to make a symbolic link from ~/.m2/repository to my
> actual repository.
>
> Lloyd
>
>
>
> On Sep 5, 2008, at 5:11 PM, Ming Zhang wrote:
>
>> Hi Lloyd,
>>
>> If your maven.repo.local is non-default
>> (${user.home}/.m2/repository), please use
>> -Dmaven.repo.local=${your_local_repo} to overwrite the property
>> defined in the quicklook/build.properties. I'll also update
>> QuickLook_Test_Instructions.html to include this.
>>
>> I'll remove the redefined maven.repo.local in other 2 places.
>>
>> Thanks,
>> Ming
>>
>> Lloyd Chambers wrote:
>>> One more thing: why do build.properties files keep redefining
>>> maven.repo.local?
>>>
>>> It's already defined in quicklook/build.properties, yet redefined in
>>> two more places.
>>>
>>> ---
>>>
>>> MB2:quicklook lloyd$ grep -r maven.repo.local .
>>> ./build.properties:maven.repo.local=${user.home}/.m2/repository
>>> ./classloader/hellojsf/build.properties:maven.repo.local=${user.home}/.m2/repository
>>>
>>> ./web/jruby/helloapp/build.properties:maven.repo.local=${user.home}/.m2/repository
>>>
>>>
>>>
>>>
>>>
>>> On Sep 5, 2008, at 4:36 PM, Lloyd Chambers wrote:
>>>
>>>> I see also that hard-coded stuff is used at the top-level
>>>> quicklook/build.properties.
>>>>
>>>> What I don't understand is how it could ever have worked for me,
>>>> yet it did. Maybe the new tests actually use the repo location
>>>> directly?
>>>>
>>>> #Edit these values for specific glassfish instance
>>>> deploy.platform=v3
>>>> glassfish.http.host=localhost
>>>> glassfish.http.port=8080
>>>> glassfish.home=C:\\Sun\\v3\\glassfish
>>>> v3=true
>>>>
>>>> maven.repo.local=${user.home}/.m2/repository
>>>> plugin_classpath=${maven.repo.local}/org/testng/testng/5.6/testng-5.6-jdk15.jar
>>>>
>>>>
>>>>
>>>>
>>>> On Sep 5, 2008, at 4:29 PM, Lloyd Chambers wrote:
>>>>
>>>>> I found the problem.
>>>>>
>>>>> It is a hard-coded repository in
>>>>> /v3/code/tests/quicklook/classloader/hellojsf/build.properties
>>>>>
>>>>> maven.repo.local=${user.home}/.m2/repository
>>>>> jsf_jar_path=${maven.repo.local}/com/sun/jsftemplating/jsftemplating-dynafaces/0.1
>>>>>
>>>>>
>>>>> This is new, and it breaks anyone who puts their local repository
>>>>> somewhere other than ~/.m2/repository (like me).
>>>>>
>>>>> Lloyd
>>>>>
>>>>>
>>>>> On Sep 5, 2008, at 3:48 PM, Lloyd Chambers wrote:
>>>>>
>>>>>> Yesterday I ran Quicklook just fine.
>>>>>>
>>>>>> Today I see this the stuff below
>>>>>> 1. Why is it doing "start-server-felix-windows" on my Mac OS X
>>>>>> system?
>>>>>> 2. Why is it using a repository that I don't use (my repo is not
>>>>>> in ~/.m2
>>>>>>
>>>>>> Lloyd
>>>>>>
>>>>>> -------------
>>>>>>
>>>>>> start-server-felix-windows:
>>>>>> [echo] Sleeping for 20 seconds while the server is starting
>>>>>>
>>>>>> build:
>>>>>> [echo] ANT PROJECT GlassFish-V3-QuickLook
>>>>>>
>>>>>> build:
>>>>>>
>>>>>> compile-tests:
>>>>>> [echo] compiling test client to ..//classes/test
>>>>>> [mkdir] Created dir: /v3/code/tests/quicklook/classes/test
>>>>>> [javac] Compiling 5 source files to
>>>>>> /v3/code/tests/quicklook/classes/test
>>>>>> [javac] Note: Some input files use unchecked or unsafe operations.
>>>>>> [javac] Note: Recompile with -Xlint:unchecked for details.
>>>>>>
>>>>>> build:
>>>>>>
>>>>>> compile-tests:
>>>>>> [echo] compiling test client to ..//classes/test
>>>>>> [javac] Compiling 2 source files to
>>>>>> /v3/code/tests/quicklook/classes/test
>>>>>>
>>>>>> build:
>>>>>> [echo] Now creating a war file ../..//dist/classloader/hellojsf.war
>>>>>> [mkdir] Created dir: /v3/code/tests/quicklook/dist/classloader
>>>>>> [INFO]
>>>>>> ------------------------------------------------------------------------
>>>>>>
>>>>>> [ERROR] BUILD ERROR
>>>>>> [INFO]
>>>>>> ------------------------------------------------------------------------
>>>>>>
>>>>>> [INFO] An Ant BuildException has occured: The following error
>>>>>> occurred while executing this line:
>>>>>> /v3/code/tests/quicklook/build.xml:61: The following error
>>>>>> occurred while executing this line:
>>>>>> /v3/code/tests/quicklook/build.xml:98: The following error
>>>>>> occurred while executing this line:
>>>>>> /v3/code/tests/quicklook/classloader/hellojsf/build.xml:54:
>>>>>> /Users/lloyd/.m2/repository/com/sun/jsftemplating/jsftemplating-dynafaces/0.1
>>>>>> not found.
>>>>>>
>>>>>> [INFO]
>>>>>> ------------------------------------------------------------------------
>>>>>>
>>>>>> [INFO] For more information, run Maven with the -e switch
>>>>>> [INFO]
>>>>>> ------------------------------------------------------------------------
>>>>>>
>>>>>> [INFO] Total time: 28 seconds
>>>>>> [INFO] Finished at: Fri Sep 05 15:45:47 PDT 2008
>>>>>> [INFO] Final Memory: 7M/14M
>>>>>> [INFO]
>>>>>> ------------------------------------------------------------------------
>>>>>>
>>>>>> MB2:quicklook lloyd$
>>>>>>
>>>>>>
>>>>>> ..............................................
>>>>>> Lloyd Chambers
>>>>>> lloyd.chambers_at_sun.com
>>>>>> GlassFish team, LSARC member
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>>>
>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>