Sahoo wrote:
>
> Bhakti Mehta wrote:
>> I have discussed this with Sahoo and Jerome. Currently as part of
>> v3/javaee-api/pom.xml we have javax.xml.ws/bind/soap/stream,
>> javax.jws. We are already exporting these packages as part of our
>> metro jaxb and webservices osgi bundles.
>> I have noticed lately the time to start metro bundles is longer
>> because of unable to resolve conflicts between the two bundles
>> exporting the same packages
>>
>> With this change
>> javax.jws,javax.xml.rpc,javax.xml.soap,javax.xml.ws,javax.xml.bind
>> will not be part of javaee-api modules (Note javax.xml.stream will be
>> there)
>> I am planning to remove these modules from javaee-api/pom.xml
>> (Commented out for now)
> No, please remove them as well as the module dirs.
Ok
>> I have already run quicklooks and tested with fresh install without .m2
>>
>> However there is a catch 22 If I make this change locally I still
>> find the javax.xml.* jars in my web.zip
>> This is because there is this pom
>> http://download.java.net/maven/glassfish/org/glassfish/javaee-api/10.0-SNAPSHOT/javaee-api-10.0-SNAPSHOT.pom
>> which still shows the modules and when the bundle is created it gets
>> the jars
> You need to remove the dependencies from javax.javaee/pom.xml as well.
> Without this, your change is incomplete.
>> I could test this locally by removing the above mentioned jars from
>> my glassfish/modules and run quicklooks
>> The changes cannot be in effect till the build succeeds and the pom
>> is updated on maven repo by hudson. I hope the build will not have
>> any issues but wanted to give a heads up.
>>
>> Pls let me know if you have any concerns. I will commit the changes
>> tomorrow around 10 am if I do not hear from anyone
>> Regards,
> Pl. make the additional changes suggested.
Yes I will make the changes thanks for the review
>
> BTW, does jsr109 implementation module not expect javax.javaee.jar to
> have all webservices API for some compiler to work? Why do you have
> this line:
> webservices/jsr109-impl/src/main/java/org/glassfish/webservices/WebServicesDeployer.java:
> classpath+=(File.pathSeparator+"javax.javaee-10.0-SNAPSHOT.jar") ;
That was a temporary hack will remove that.
Regards,
Bhakti
>
> Thanks,
> Sahoo
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>
>