Hi, Ken.
I am having a similar discussion with Sahoo about whether the
gui-plugin-common module should be versioned of a snapshot. The web GUI
plug-in will share this module with the web container and so will evolve
"jointly" with the plug-in and the container.
This is a little bit different situation from what you are describing
because in contrast to the GUI itself, I would think the web plug-in and
the web container should evolve together.
Building the gui-plugin-common module as a snapshot is easier in some
respects. Are we setting ourselves up for problems down the road by
following that approach, do you think?
- Tim
Ken Paulsen wrote:
> Hi Kedar,
>
> It is important for the admingui to keep separate versions so that it
> may support multiple builds of GlassFish. This will be particularly
> important after Prelude ships so that we can continue to release admin
> console plugins (and even the .war itself) which are compatible with
> Prelude and post-prelude builds. At some point, our bits will require
> newer features (from HK2, or glassfish-api, etc.), at which point we
> will need to manually update that dependency in our pom.xml to reflect
> the new minimum version requirement. If we ALWAYS take the latest
> version, we will ALWAYS be incompatible with all older versions of
> every dependency. This would be very unfortunate.
>
> Thanks,
>
> Ken
>
> Kedar Mhaswade wrote:
>> In that case, please inherit most of the dependencies and their
>> versions from parent POM, e.g. glassfish-api, hk2 versions used
>> by admingui are different from what rest of the v3 sources use.
>>
>> Anissa Lam wrote:
>>>
>>> Thanks for fixing the pom.xml for us.
>>> admingui is not part of v3 build originally because we started
>>> working on it later than most of the modules. Not including that
>>> as part of v3 build so that it won't causes any v3 build failure.
>>> I think this is no longer a valid reason.
>>> It is fine with me that admingui becomes part of the build now.
>>> Should i go ahead and include admingui in the top level pom ? With
>>> this, we don't need separate Hudson job for admingui also.
>>> thanks
>>> Anissa.
>>>
>>> Sahoo wrote:
>>>> JDK 5 is fine. The error indicates that your code
>>>> direcctly/indirectly depends on StAX (javax.xml.stream), but the
>>>> pom does not specify it. The pom was earlier relying on transitive
>>>> dependencies to get StAX. We changed HK2 to not export its
>>>> dependencies to others, so that we have a chance to ship some other
>>>> version of StAX. That has caused this problem. I checked a change
>>>> [rev 21581] that fixes the issue.
>>>>
>>>> By the way, why is admingui not part of v3 build? I understand your
>>>> team wants to only build admingui separately, but that does not
>>>> stop it from being part of v3 build.
>>>>
>>>> Thanks,
>>>> Sahoo
>>>>
>>>> Anissa Lam wrote:
>>>>> Hi,
>>>>> Is there new requirement that we need to use Java 6 to build v3 ?
>>>>> I just checked out a fresh workspace and got the following error
>>>>> when building admingui.
>>>>>
>>>>> [INFO] [hk2:hk2-compile]
>>>>> [INFO] Compiling 4 source files to
>>>>> /Users/anilam/Awork/V3/v3-test/v3/admingui/plugin-service/target/classes
>>>>>
>>>>> /Users/anilam/Awork/V3/v3-test/v3/admingui/plugin-service/src/main/java/org/glassfish/admingui/plugin/ConsolePluginService.java:118:
>>>>> cannot access javax.xml.stream.XMLStreamReader
>>>>> file javax/xml/stream/XMLStreamReader.class not found
>>>>> DomDocument doc = parser.parse(url);
>>>>> ^
>>>>> Note:
>>>>> /Users/anilam/Awork/V3/v3-test/v3/admingui/plugin-service/target/apt-generated-sources/org/glassfish/admingui/plugin/ConsoleConfigInjector.java
>>>>> uses unchecked or unsafe operations.
>>>>> Note: Recompile with -Xlint:unchecked for details.
>>>>> 1 error
>>>>> [INFO]
>>>>> ------------------------------------------------------------------------
>>>>>
>>>>> [ERROR] BUILD ERROR
>>>>> [INFO]
>>>>> ------------------------------------------------------------------------
>>>>>
>>>>> [INFO] Fatal error compiling
>>>>>
>>>>>
>>>>> ConsolePluginService doesn't invoke that api directory, think its
>>>>> through HK2.
>>>>> The HK2 source code uses Java 6 only api's, does it mean we can
>>>>> no longer build on java 5 anymore ? Is this new requirement ? I
>>>>> was able to build on the weekends.
>>>>> I am still running Mac OS 10.4, i hope i don't need to upgrade my
>>>>> OS in order to continue my development since there is no Java 6 on
>>>>> Mac 10.4 yet.
>>>>>
>>>>> thanks
>>>>> Anissa
>>>>>
>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>