dev@glassfish.java.net

Re: [Attn Harpreet: Your checkin broke build for several hours] Re: compilation error when trying to build flashlight/framework

From: Lloyd Chambers <Lloyd.Chambers_at_Sun.COM>
Date: Fri, 18 Jul 2008 12:09:38 -0700

I certainly sympathize. Right now there is too much to learn and know.

On Jul 18, 2008, at 12:07 PM, Harpreet Singh wrote:

> Sahoo et al,
>
> Apologize for this - I am not too familiar with the v3
> infrastructure and I thought I had done my due diligence in terms of
> building everything from source. Seems like I missed something
> obvious.
> - Harpreet
>
> Sahoo wrote:
>>
>> We continue to cause build failures for hours together. It is
>> frustrating for developers who do want to follow the process and
>> can't get their work done because of mistakes of others. Despite
>> several requests, it appears that developers are not checking
>> Hudson after check-ins. The build [1] failed for a very simple
>> reason, a method name of interface/abstract class was changed, but
>> the implementation was not changed;
>>
>> [INFO] Compiling 7 source files to /files/Hudson/workspace/
>> glassfish-v3-devbuild/v3/flashlight/framework/target/classes
>> /files/Hudson/workspace/glassfish-v3-devbuild/v3/flashlight/
>> framework/src/main/java/org/glassfish/flashlight/impl/provider/
>> FlashlightProbeProviderFactory.java:51:
>> org
>> .glassfish.flashlight.impl.provider.FlashlightProbeProviderFactory
>> is not abstract and does not override abstract method
>> <
>> T
>> >
>> getProbeProvider
>> (java
>> .lang.String,java.lang.String,java.lang.String,java.lang.Class<T>)
>> in org.glassfish.flashlight.provider.ProbeProviderFactory
>> public class FlashlightProbeProviderFactory
>> ^
>>
>>
>> A clean build in the local workspace should have caught it, right?
>> OK, we got past the first barrier. How about the second check post
>> - Hudson? A look at Hudson build status would have been sufficient
>> to control the damage to only 30 mins. The build started failing at
>> around 1630 PDT on Thursday and was not fixed until Jerome did so
>> around 0200 PDT, causing the system to be in a bad state for *~8
>> hours*. This included first half of working hours for Indian
>> developers.
>>
>> I understand that we don't have the best build system yet, so that
>> calls for extra caution from developers.
>>
>> Thanks,
>> Sahoo
>>
>> [1] http://hudson.sfbay/view/GFv3/job/glassfish-v3-devbuild/2039/changes#detail0
>>
>> Anissa Lam wrote:
>>>
>>> After 'svn update', i cannot build the server any more. Here is
>>> the error. Hudson is also showing the same.
>>> Hope someone can take a look.
>>>
>>> thanks.
>>> Anissa.
>>>
>>>
>>> [INFO]
>>> ------------------------------------------------------------------------
>>> [INFO] Building GlassFish Flashlight Framework
>>> [INFO] task-segment: [install]
>>> [INFO]
>>> ------------------------------------------------------------------------
>>> [INFO] [resources:resources]
>>> [INFO] Using default encoding to copy filtered resources.
>>> [INFO] snapshot org.glassfish.flashlight:flashlight-agent:10.0-
>>> SNAPSHOT: checking for updates from glassfish-repository
>>> [INFO] snapshot org.glassfish.flashlight:flashlight-agent:10.0-
>>> SNAPSHOT: checking for updates from glassfish-repository-wsinterop
>>> [INFO] snapshot org.glassfish.flashlight:flashlight-agent:10.0-
>>> SNAPSHOT: checking for updates from java-dev-repository
>>> [INFO] snapshot org.glassfish.flashlight:flashlight-agent:10.0-
>>> SNAPSHOT: checking for updates from repo1.maven.org
>>> [INFO] snapshot org.glassfish.flashlight:flashlight-agent:10.0-
>>> SNAPSHOT: checking for updates from maven2.java.net
>>> [INFO] snapshot org.glassfish.flashlight:flashlight-agent:10.0-
>>> SNAPSHOT: checking for updates from maven2.java.net-backup
>>> [INFO] [hk2:hk2-compile]
>>> [INFO] Compiling 7 source files to /export/Users/anilam/Awork/V3/
>>> v3-new/v3/flashlight/framework/target/classes
>>> /export/Users/anilam/Awork/V3/v3-new/v3/flashlight/framework/src/
>>> main/java/org/glassfish/flashlight/impl/provider/
>>> FlashlightProbeProviderFactory.java:51:
>>> org
>>> .glassfish.flashlight.impl.provider.FlashlightProbeProviderFactory
>>> is not abstract and does not override abstract method
>>> <
>>> T
>>> >
>>> getProbeProvider
>>> (java
>>> .lang.String,java.lang.String,java.lang.String,java.lang.Class<T>)
>>> in org.glassfish.flashlight.provider.ProbeProviderFactory
>>> public class FlashlightProbeProviderFactory
>>> ^
>>> Note: /export/Users/anilam/Awork/V3/v3-new/v3/flashlight/framework/
>>> src/main/java/org/glassfish/flashlight/impl/provider/
>>> FlashlightProbeProviderFactory.java uses unchecked or unsafe
>>> operations.
>>> Note: Recompile with -Xlint:unchecked for details.
>>> 1 error
>>> [INFO]
>>> ------------------------------------------------------------------------
>>> [ERROR] BUILD ERROR
>>> [INFO]
>>> ------------------------------------------------------------------------
>>> [INFO] Fatal error compiling
>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>