Jerome,
Jerome Dochez wrote:
> Nandini
>
> ok so I think I fixed it and the commands are now looked up properly
> from the realms module. I could see the commands in the list of
> available commands and I could run the --help on some of them so I
> think we should still have a functional set of commands.
I rechecked those commands on a fresh build. Barring a couple of
cosmetic issues, basic working looks good. Thanks.
Nandini
> It was partly my fault that this was not work, so I felt compelled
> fixing it ;-)
> let me know if you see any problems with the checkin.
>
> jerome
>
> On Jun 26, 2008, at 8:55 AM, Nandini Ektare wrote:
>
>> Jerome Dochez wrote:
>>> On Jun 26, 2008, at 2:17 AM, Nandini Ektare wrote:
>>>> Jerome Dochez wrote:
>>>>> this is incorrect.
>>>> Regressing on existing tp2 functionality is unacceptable.
>>> nobody is talking about regressing on any functionality.
>>>>> kernel must not depend on realms which depends on DOL which
>>>>> depends on many things including the Java EE Apis.
>>>>> 1. the classes you just checked in already existed in the realm
>>>>> module where they got moved some time back.
>>>> That move regressed tp2 functionality because all the 7 missing
>>>> (moved) commands are no longer available (refer to issue 5112).
>>>> QA has been blocked on missing commands. I wonder how this slipped
>>>> during verification testing after the classes were moved.
>>> verification testing... you mean we have devtests ;-) ?
>> No, I mean a simple quick verification using the good old asadmin
>> <command> after every command is moved. :-)
>>>> With ref to issue 5112, I had written to you for details on why the
>>>> commands corresponding to these classes were left out in trunk. I
>>>> received no replies.
>>>>
>>>> I did not find them in the dir they were checked in, and the
>>>> functionality was broken; I concluded classes were perhaps left out
>>>> inadvertently during tp2 branch to trunk syncing. (see my comments
>>>> in 5112).
>>> I understood that part, not a big problem, it's the kernel
>>> dependency change that triggers my interest...
>> From what I understand it is a big problem for QA. They do not have a
>> stable v3 lite promoted build and are behind the schedule.
>> 5112 is marked as a P2.
>>>>> 2. never modify the import list of kernel and nucleus related
>>>>> modules without talking to myself or sahoo first.
>>>> Likewise, appreciate if we are made aware of modifications such as
>>>> moving of the classes in admin. No one in admin team seems to be
>>>> aware of this move.
>>>>> Please revert this change and fix anything that needs to be fixed
>>>>> in the Realm module directly.
>>>> I can revert my change but then moved classes need to work from
>>>> their new location. QA will be stuck otherwise. Let me know.
>>> yes we need to move them back or delete the new ones since it's
>>> still located in the old place and then we need to understand why
>>> they are not found. In theory, the location of the command
>>> implementation is immaterial to the lookup and resolution of the
>>> command. However, since it does not work, there is an obvious issue
>>> we will need to investigate.
>> Right. How about we first find the cause and I will revert the
>> changes after that? That way QA will not have to wait unnecessarily.
>>
>> Thanks,
>> Nandini
>>> After the revert is done and we fix the realm module, we need to add
>>> a few devtests to ensure such a situation does not reproduce again.
>>> Jane had a few tests for some admin commands, you might be able to
>>> leverage that.
>>> Thanks, jerome
>>>> thanks,
>>>> Nandini
>>>>> thanks, jerome
>>>>>
>>>>> On Jun 25, 2008, at 6:22 PM, ne110415_at_dev.java.net wrote:
>>>>>
>>>>>> Author: ne110415
>>>>>> Date: 2008-06-26 01:22:06+0000
>>>>>> New Revision: 21133
>>>>>>
>>>>>> Modified:
>>>>>> trunk/v3/core/kernel/pom.xml
>>>>>>
>>>>>> Log:
>>>>>> Missing commands from TP2. Issue 5112 gets addressed.
>>>>>>
>>>>>> Modified: trunk/v3/core/kernel/pom.xml
>>>>>> Url:
>>>>>> https://glassfish-svn.dev.java.net/source/browse/glassfish-svn/trunk/v3/core/kernel/pom.xml?view=diff&rev=21133&p1=trunk/v3/core/kernel/pom.xml&p2=trunk/v3/core/kernel/pom.xml&r1=21132&r2=21133
>>>>>>
>>>>>> ==============================================================================
>>>>>>
>>>>>> --- trunk/v3/core/kernel/pom.xml (original)
>>>>>> +++ trunk/v3/core/kernel/pom.xml 2008-06-26 01:22:06+0000
>>>>>> @@ -102,6 +102,11 @@
>>>>>> <version>${hk2.version}</version>
>>>>>> </dependency>
>>>>>> <dependency>
>>>>>> + <groupId>org.glassfish.security</groupId>
>>>>>> + <artifactId>realms</artifactId>
>>>>>> + <version>${project.version}</version>
>>>>>> + </dependency>
>>>>>> + <dependency>
>>>>>> <groupId>org.glassfish.external</groupId>
>>>>>> <artifactId>grizzly-module</artifactId>
>>>>>> <version>${grizzly.version}</version>
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>> To unsubscribe, e-mail:
>>>>>> commits-unsubscribe_at_glassfish-svn.dev.java.net
>>>>>> For additional commands, e-mail:
>>>>>> commits-help_at_glassfish-svn.dev.java.net
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>