Done.
Vivek Pandey wrote:
> If this fix look ok, can someone integrate it to hk2 as this is
> important for grails to work with v3?
>
> thanks,
>
> -vivek.
>
> Sahoo wrote:
>> Are you saying that there is a jar file which does not have
>> META-INF/MANIFEST.MF in it? Never knew that's possible, but that was
>> my ignorance. Looking at the javadoc of JarFile.getManifest(), I see
>> you have proposed a valid fix.
>>
>> Thanks,
>> Sahoo
>>
>> Martin Grebac wrote:
>>> Hi,
>>> I'm getting the NPE below from hk2 trying to make my groovy sniffer
>>> work with v3:
>>>
>>> [#|2008-03-31T10:26:42.684+0200|SEVERE|GlassFish10.0|javax.enterprise.system.tools.deployment|_ThreadID=11;_ThreadName=Thread-4;|Exception
>>> while deploying the app
>>> java.lang.NullPointerException
>>> at
>>> com.sun.enterprise.module.common_impl.DefaultModuleDefinition.parseClassPath(DefaultModuleDefinition.java:153)
>>>
>>> at
>>> com.sun.enterprise.module.common_impl.DefaultModuleDefinition.<init>(DefaultModuleDefinition.java:101)
>>>
>>> at
>>> com.sun.enterprise.module.impl.CookedModuleDefinition.<init>(CookedModuleDefinition.java:50)
>>>
>>> at
>>> com.sun.enterprise.groovy.GroovySniffer.setup(GroovySniffer.java:81)
>>> at
>>> com.sun.enterprise.v3.server.ContainerStarter.startContainer(ContainerStarter.java:103)
>>>
>>> at
>>> com.sun.enterprise.v3.server.ApplicationLifecycle.setupContainer(ApplicationLifecycle.java:742)
>>>
>>> at
>>> com.sun.enterprise.v3.server.ApplicationLifecycle.setupContainerInfos(ApplicationLifecycle.java:411)
>>>
>>> at
>>> com.sun.enterprise.v3.server.ApplicationLifecycle.deploy(ApplicationLifecycle.java:275)
>>>
>>>
>>> the issue is that some of the jars from grails don't include metadata
>>> element. May I fix it (see attached patch) or is there anything wrong
>>> with what I do?
>>>
>>> Thanks,
>>> MartinG
>>>
>>> ------------------------------------------------------------------------
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>
>
--
Kohsuke Kawaguchi
Sun Microsystems kohsuke.kawaguchi_at_sun.com