dev@glassfish.java.net

Re: CVS update: /glassfish/admin/mbeanapi-impl/src/java/com/sun/enterprise/management/config/ConnectorConnectionPoolConfigFactory.java

From: Dinesh Patil <Dinesh.Patil_at_Sun.COM>
Date: Tue, 22 May 2007 09:59:07 -0700

Lloyd,
This checkin broke the build from yesterday evening 5pm.. This affected the nightly builds also..
please fix this asap.

    [java] mbeanapi-impl:
    [java]
    [java] init:
    [java] [mkdir] Created dir: /export/tinderbox/smoke/SunOS_5.9_depend/workspace/glassfish/admin/mbeanapi-impl/build
    [java]
    [java] compile:
    [java] [javac] Compiling 420 source files to /export/tinderbox/smoke/SunOS_5.9_depend/workspace/glassfish/admin/mbeanapi-impl/build
    [java] [javac] /export/tinderbox/smoke/SunOS_5.9_depend/workspace/glassfish/admin/mbeanapi-impl/src/java/com/sun/enterprise/management/config/ConnectorConnectionPoolConfigFactory.java:121: cannot find symbol
    [java] [javac] symbol : method getConnectorModuleConfigMap()
    [java] [javac] location: interface com.sun.appserv.management.config.DomainConfig
    [java] [javac] getDomainRoot().getDomainConfig().getConnectorModuleConfigMap();
    [java] [javac] ^
    [java] [javac] Note: Some input files use or override a deprecated API.
    [java] [javac] Note: Recompile with -Xlint:deprecation for details.
    [java] [javac] 1 error
    [java]
    [java] BUILD FAILED
    [java] /export/tinderbox/smoke/SunOS_5.9_depend/workspace/glassfish/admin/build.xml:77: The following error occurred while executing this line:
    [java] /export/tinderbox/smoke/SunOS_5.9_depend/workspace/glassfish/admin/mbeanapi-impl/build.xml:92: Compile failed; see the compiler error output for details.
    [java]
    [java] Total time: 1 minute 33 seconds
    [java] [ERROR] Java Result: 1


llc_at_dev.java.net wrote:

>User: llc
>Date: 2007-05-21 23:25:13+0000
>Log:
> Tested using genericra.rar, deploying it in GUI.
>
> Issue number: 2681
> Obtained from:
> Submitted by: Lloyd Chambers
> Reviewed by: Kshitiz Saxena
>
>File Changes:
>
>Directory: /glassfish/admin/mbeanapi-impl/src/java/com/sun/enterprise/management/config/
>========================================================================================
>
>File [changed]: ConnectorConnectionPoolConfigFactory.java
>Url: https://glassfish.dev.java.net/source/browse/glassfish/admin/mbeanapi-impl/src/java/com/sun/enterprise/management/config/ConnectorConnectionPoolConfigFactory.java?r1=1.7&r2=1.8
>Delta lines: +20 -16
>---------------------
>--- ConnectorConnectionPoolConfigFactory.java 2007-05-05 05:23:17+0000 1.7
>+++ ConnectorConnectionPoolConfigFactory.java 2007-05-21 23:25:10+0000 1.8
>@@ -35,9 +35,9 @@
> */
>
> /*
>- * $Header: /cvs/glassfish/admin/mbeanapi-impl/src/java/com/sun/enterprise/management/config/ConnectorConnectionPoolConfigFactory.java,v 1.7 2007/05/05 05:23:17 tcfujii Exp $
>- * $Revision: 1.7 $
>- * $Date: 2007/05/05 05:23:17 $
>+ * $Header: /cvs/glassfish/admin/mbeanapi-impl/src/java/com/sun/enterprise/management/config/ConnectorConnectionPoolConfigFactory.java,v 1.8 2007/05/21 23:25:10 llc Exp $
>+ * $Revision: 1.8 $
>+ * $Date: 2007/05/21 23:25:10 $
> */
>
>
>@@ -55,6 +55,7 @@
>
> import com.sun.appserv.management.config.DomainConfig;
> import com.sun.appserv.management.config.ResourceAdapterConfig;
>+import com.sun.appserv.management.config.ConnectorModuleConfig;
>
> import com.sun.appserv.management.util.misc.MapUtil;
> import com.sun.appserv.management.util.misc.GSetUtil;
>@@ -110,17 +111,20 @@
> }
>
>
>- static final Set<String> IMPLICIT_RESOURCE_ADAPTERS = GSetUtil.newStringSet( "jmsra", "jaxr-ra" );
>+ private static final Set<String> IMPLICIT_RESOURCE_ADAPTERS = GSetUtil.newStringSet( "jmsra", "jaxr-ra" );
> private void
> checkResourceAdapterExists( final String resourceAdapterName )
> {
>- final Map<String,ResourceAdapterConfig> resourceAdapters =
>- getDomainRoot().getDomainConfig().getResourceAdapterConfigMap();
>+ final DomainConfig domainConfig = getDomainRoot().getDomainConfig();
>
>- if( ! ( resourceAdapters.containsKey( resourceAdapterName ) ||
>- IMPLICIT_RESOURCE_ADAPTERS.contains( resourceAdapterName ) ) )
>- {
>- throw new IllegalArgumentException( "No resource adapter exists with the name: " + resourceAdapterName );
>+ final Map<String,ConnectorModuleConfig> connectorModules =
>+ getDomainRoot().getDomainConfig().getConnectorModuleConfigMap();
>+ if ( ! connectorModules.containsKey(resourceAdapterName) )
>+ {
>+ throw new IllegalArgumentException(
>+ "No ResourceAdapterConfig or " +
>+ "ConnectorModuleConfig exists with the name: " +
>+ resourceAdapterName );
> }
> }
>
>
>
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: cvs-unsubscribe_at_glassfish.dev.java.net
>For additional commands, e-mail: cvs-help_at_glassfish.dev.java.net
>
>
>