Bill Shannon wrote:
> Dinesh Patil wrote:
>
>> Bill Shannon wrote:
>>
>>> Dinesh Patil wrote:
>>>
>>>> I didn't see the obvious failure from the huge complete build.errs
>>>> or short build.errs.filtered as well.. This seems to be the output
>>>> of build and javadoc command, so error may be later on..
>>>
>>>
>>>
>>> There's a whole bunch of code that doesn't compile successfully.
>>> Why is that not an obvious build failure?
>>
>>
>> I didn't find any messages in your build log that shows compiler errors.
>
>
> Hmmm... Ok, maybe I didn't look closely enough. Maybe all this
> compiler output is just warnings.
yes that's what I could see.. all those are just warnings that are
always there since glassfish.. my rest of the comments inline.
> I think we had this discussion before... Is it impossible to fix the
> code so that the compiler doesn't complain? Certainly some of the
> warnings suggest that it is possible:
>
> [java] [javac]
> /cache/tmp/glassfish-build/glassfish/tools/src/java/com/s
> un/enterprise/tools/common/ui/MVCUtils.java:140: warning: non-varargs
> call of va
> rargs method with inexact argument type for last parameter;
> [java] [javac] cast to java.lang.Object for a varargs call
> [java] [javac] cast to java.lang.Object[] for a non-varargs
> call and to
> suppress this warning
>
> Why aren't these being fixed?
I tried to reduce some of those, it used to be @100 when we had this
discussion, and I sent it to module/program owners to take a look at
some complex warnings that I couldn't fix.. We may have to take up that
exercise again, as this still not fixed.
> Ok, you're right. I got an awk script to get rid of all the javac
> warnings. That leaves me with this:
Yes. that's why I said we need to validate first if build is really
failing in compilation or some other steps.. so your awk script can have
different patterns to catch such issues.
> [java] Overriding previous definition of reference to
> compile.classpath
> [java] Overriding previous definition of reference to
> catalina.classpath
> [java] Overriding previous definition of reference to pwc.classpath
> [java] [delete]
> /cache/tmp/glassfish-build/glassfish/jacc-provider/build
> not found.
> [java] [delete]
> /cache/tmp/glassfish-build/glassfish/container-auth/build
> not found.
> [java] [delete]
> /cache/tmp/glassfish-build/glassfish/jmac-provider/build
> not found.
> [java] [delete]
> /cache/tmp/glassfish-build/glassfish/appserv-core/build n
> ot found.
> [java] Overriding previous definition of reference to
> compile.classpath
> [java] Overriding previous definition of reference to
> grizzly.classpath
> [java] [delete]
> /cache/tmp/glassfish-build/glassfish/jdbcra/build not fou
> nd.
> [java] [delete] /cache/tmp/glassfish-build/glassfish/jdbcra/tmp
> not found
> .
> [java] [delete]
> /cache/tmp/glassfish-build/glassfish/tools/build not foun
> d.
> [java] [delete] /cache/tmp/glassfish-build/glassfish/avk/build
> not found.
> [java] [delete] /cache/tmp/glassfish-build/glassfish/avk/help
> not found.
> BUILD SUCCESSFUL
> Total time: 1 minutes 54 seconds
> Finished at: Fri Mar 16 06:06:56 PDT 2007
> [cvs] cvs server: [06:10:12] waiting for guest's lock in
> /cvs/glassfish/apps
> erv-core/src/java/com/sun/enterprise/server/logging/logviewer
> [cvs] cvs server: [06:10:42] obtained lock in
> /cvs/glassfish/appserv-core/sr
> c/java/com/sun/enterprise/server/logging/logviewer
> [cvs] M glassfish/admin-core-ee/dtds/admin-mbeans-descriptors-ee.xml
> [cvs] M glassfish/admin-ee/templates/ee80/default-domain.xml.template
> glassfish-src
> Attempting to download com-sun-commons-modeler-1.1-20070315.jar.
> 6/95K^M12/95K^M17/95K^M24/95K^M30/95K^M32/95K^M39/95K^M45/95K^M52/95K^M61/95K^M6
>
> 8/95K^M75/95K^M78/95K^M84/95K^M88/95K^M95/95K^M95K downloaded
> [chmod] Skipping fileset for directory
> /cache/tmp/glassfish-build/publish/gl
> assfish/lib. It is empty.
> [jar] overview.html already added, skipping
> [chmod] Skipping fileset for directory
> /cache/tmp/glassfish-build/publish/gl
> assfish/lib. It is empty.
> persistence
> <extend>../bootstrap/maven.xml</extend>build:start:
> [java] [javac] Note:
> /cache/tmp/glassfish-build/glassfish/deployment-api
> /src/java/javax/enterprise/deploy/shared/factories/DeploymentFactoryManager.java
>
> uses unchecked or unsafe operations.
> [java] [javadoc]
> /cache/tmp/glassfish-build/glassfish/servlet-api/src/jsr2
> 45/src/share/javax/el/ELContext.java:73: warning - Tag @link:
> reference not foun
> d: javax.faces.context.FacesContext
> [java] [javadoc]
> /cache/tmp/glassfish-build/glassfish/servlet-api/src/jsr2
> 45/src/share/javax/el/ELUtil.java:57: warning - Tag @link: reference
> not found:
> FacesContext
> [java] [javadoc]
> /cache/tmp/glassfish-build/glassfish/servlet-api/src/jsr2
> 45/src/share/javax/el/ELUtil.java:57: warning - Tag @link: reference
> not found:
> FacesContext
> [java] [javadoc]
> /cache/tmp/glassfish-build/glassfish/servlet-api/src/jsr2
> 45/src/share/javax/el/ELUtil.java:57: warning - Tag @link: reference
> not found:
> FacesContext
> [java] [javadoc] 4 warnings
> [java] Overriding previous definition of reference to
> compile.classpath
> [java] [rmic] RMI Compiling 1 class to
> /cache/tmp/glassfish-build/glass
> fish/appserv-commons/build
> [java] [rmic] IIOP has been turned on.
> [java] Overriding previous definition of reference to
> catalina.classpath
> [java] Overriding previous definition of reference to pwc.classpath
> [java] [ear] Warning: selected ear files include a
> META-INF/applicatio
> n.xml which will be ignored (please use appxml attribute to ear task)
> [java] Overriding previous definition of reference to
> compile.classpath
> [java] Overriding previous definition of reference to
> grizzly.classpath
> [java] [java] Renamed property from "CheckAllAtCommit" to
> "CheckAllAtCo
> mmit2" in "Consistency", due to duplicate names or a forbidden name.
> [java] [java] The root element is 'sun-cmp-mappings' and its
> class is '
> SunCmpMappings'.
> [java] [java]
> /cache/tmp/glassfish-build/glassfish/cmp/support/ejb/src/
> com/sun/jdo/spi/persistence/support/ejb/ejbqlc/Semantic.g:1476:28:
> warning:Label
> ed subrules not yet supported
> [java] [java]
> /cache/tmp/glassfish-build/glassfish/cmp/support/ejb/src/
> com/sun/jdo/spi/persistence/support/ejb/ejbqlc/Semantic.g:1476:28:
> warning:Label
> ed subrules not yet supported
> [java] [java]
> /cache/tmp/glassfish-build/glassfish/cmp/support/ejb/src/
> com/sun/jdo/spi/persistence/support/ejb/ejbqlc/Semantic.g:1480:32:
> warning:Label
> ed subrules not yet supported
> [java] [java]
> /cache/tmp/glassfish-build/glassfish/cmp/support/ejb/src/
> com/sun/jdo/spi/persistence/support/ejb/ejbqlc/Semantic.g:1480:32:
> warning:Label
> ed subrules not yet supported
> [java] [locjar] Building localized jar:
> /cache/tmp/glassfish-build/glassf
> ish/cmp/support/jars/locale/persistence-rt_ja.jar
> [java] [locjar] Building localized jar:
> /cache/tmp/glassfish-build/glassf
> ish/cmp/support/jars/persistence-rt.jar
> [java] [locjar] Building localized jar:
> /cache/tmp/glassfish-build/glassf
> ish/cmp/mapping/ejb/jars/persistence-mapping-ejb.jar
> [java] [locjar] Building localized jar:
> /cache/tmp/glassfish-build/glassf
> ish/cmp/generator/database/jars/persistence-generator-database.jar
> [java] build_sub_components:
> admin-ee
> <extend>../bootstrap/maven.xml</extend><extend>../bootstrap/maven.xml</extend>bu
>
> ild:start:
> appserv-core-ee
> <extend>../bootstrap/maven.xml</extend><extend>../bootstrap/maven.xml</extend>bu
>
> ild:start:
> [java] [java] ******** in addTextTOElement **********
> [java] [java] ******** in addTextTOElement **********
> [java] [exec] Buildfile: aptbuild.xml
> [java] [exec] compile:
> [java] [exec] [echo] JSFTEMP = lib/jsftemplating-dt.jar
> [java] [exec] [apt] Compiling 123 source files to
> /cache/tmp/glas
> sfish-build/glassfish/admin-gui/build/WEB-INF/classes
> [java] [exec] [apt] warning: Annotation types without
> processors:
> [java.lang.SuppressWarnings]
> [java] [exec] [apt] Note:
> /cache/tmp/glassfish-build/glassfish/ad
> min-gui/src/java/com/sun/enterprise/tools/admingui/handlers/ConfigurationHandler
>
> s.java uses or overrides a deprecated API.
> [java] [exec] [apt] 1 warning
> BUILD SUCCESSFUL
> Total time: 34 minutes 9 seconds
> Finished at: Fri Mar 16 06:41:11 PDT 2007
>
>
> Some of those are obviously things that I could safely ignore. But which
> of them are things that *could* be fixed by changing the code or build
> files?
>
> For example, why is this line needed?
>
> [java] [exec] [echo] JSFTEMP = lib/jsftemplating-dt.jar
>
> And what is producing lines of this type?
>
> [java] [java]
> /cache/tmp/glassfish-build/glassfish/cmp/support/ejb/src/
> com/sun/jdo/spi/persistence/support/ejb/ejbqlc/Semantic.g:1476:28:
> warning:Label
> ed subrules not yet supported
>
> If it's ok that labeled subrules (whatever those are) are not yet
> supported,
> can we fix the source file to not use them?
Yes sure, I think we need to identify such things and let the owners
look into this.. Your awk script will help a lot there..
I will send it to the module/program owners next week.
thanks
Dinesh
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>