Dinesh Patil wrote:
> Kohsuke Kawaguchi wrote:
>
>> Dinesh Patil wrote:
>>
>>> Kohsuke,
>>> Updated Build instructions with the feedback below. Please review it
>>> and let me know if you see anything missing.
>>> https://glassfish.dev.java.net/public/BuildGlassFish.html
>>
>>
>>
>> I think it's shorter now, so that's good.
>>
>> Fonts aren't done correctly. You aren't closing </pre>.
>
we have <code> tags for commands or code snippet so there is no issue on
</pre>, checked it..
now document is updated so its much shorter and clearer instructions.
thanks
Dinesh
> yes will fix this.
>
>> I think it's also incorrect to say:
>>
>> This may take much longer depending on your Computer and ISP speed.
>>
>> My understanding is that "maven checkout" will checkout all the
>> modules. So it shouldn't make any difference in terms of the build time.
>
>
> Yes that's correct, but user has option to checkout only required
> modules using -Dmodules=appserv-core so not required to checkout all
> the modules which may take longer.
>
> But this in context where we are specifying "maven checkout" this is
> not applicable, so will remote or rephrase it.
> thanks
> Dinesh
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>